fix(cli): remember bash permission migration by noobezlol · Pull Request #12642 · Kilo-Org/kilocode

noobezlol · 2026-07-29T11:06:22Z

Issue

Context

The compatibility migration that preserved bash: "allow" for existing users ran on every startup without recording completion. Deleting the generated permission therefore made the next startup treat the config as unmigrated and insert it again.

The same missing state could also misclassify a fresh installation later: once its schema-only config gained an unrelated setting, a future startup could treat it as an older config and add bash: "allow".

Implementation

Record completion of the bash permission migration in the global Kilo config directory. Completion is recorded whether the installation was migrated, already had an explicit permission, or was identified as fresh. Once recorded, later user edits are left untouched.

Marker writes are best-effort so a read-only config directory with an already valid permission cannot prevent startup.

Screenshots / Video

N/A — this changes config migration behavior without changing the UI.

How to Test

bun test test/kilocode/config/config.test.ts — 34 passed
bun run typecheck in packages/opencode
Targeted oxlint on the changed source and test files — 0 warnings, 0 errors
OpenCode annotation and Markdown table guards
git diff --check

Reviewer test steps

Start with an existing global config that has no permission.bash.
Start Kilo once and confirm the compatibility migration adds bash: "allow".
Delete only the generated bash permission and restart Kilo.
Confirm the permission remains deleted.

Checklist

Issue linked above
Tests and verification described
Screenshots marked N/A
Changeset included

kilo-code-bot · 2026-07-29T11:12:23Z

@@ -344,13 +345,20 @@ export namespace KilocodeConfig {
   * behavior now that the new default is `bash: "ask"`.


SUGGESTION: Docstring doesn't mention the new idempotency marker

The function's core fix in this PR is recording completion via .bash-permission-migrated so a later deletion of permission.bash (or an unrelated config edit on a fresh install) isn't re-migrated. Worth a line in the docstring explaining this, since the existing comment only describes the one-time write and not the marker-based skip-on-subsequent-runs behavior that this PR adds.

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

kilo-code-bot · 2026-07-29T11:12:33Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

packages/opencode/src/kilocode/config/config.ts
packages/opencode/test/kilocode/config/config.test.ts

Previous Review Summaries (2 snapshots, latest commit abbeb3a)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit `abbeb3a`)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

packages/opencode/src/kilocode/config/config.ts
packages/opencode/test/kilocode/config/config.test.ts

Previous review (commit `c6acd28`)

Status: 1 Issue Found | Recommendation: Merge

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
`packages/opencode/src/kilocode/config/config.ts`	345	Docstring doesn't mention the new idempotency marker behavior

The migration logic is sound: the marker is checked first and short-circuits on every path (new user, explicit permission already set, schema-only file, legacy TOML, and after the write), all writes are entirely within packages/opencode/src/kilocode/ (no shared-file merge risk), the marker write is correctly best-effort (failures are logged, never thrown), and the new tests exercise real filesystem behavior without mocks, covering the two scenarios described in the issue (deleted permission not restored, fresh install not later misclassified). A changeset is included and reads well for end users.

Files Reviewed (3 files)

.changeset/quiet-bash-permissions.md
packages/opencode/src/kilocode/config/config.ts - 1 issue
packages/opencode/test/kilocode/config/config.test.ts

_{Reviewed by grok-4.6 · Input: 130.1K · Output: 9.9K · Cached: 554.8K}

_{Review guidance: REVIEW.md from base branch main}

…sion-remigration

…sion-remigration # Conflicts: # packages/opencode/src/kilocode/config/config.ts

johnnyeric · 2026-08-27T11:03:28Z

    // A schema-only file is generated for editor completion. It does not mean
    // the user predates the bash permission default.
-    if (!hasLegacy && configs.every((item) => Object.keys(item.data).every((key) => key === "$schema"))) return
+    if (!hasLegacy && configs.every((item) => Object.keys(item.data).every((key) => key === "$schema"))) return done()


After these changes the migration will be marked as done even in cases of unreadable or malformed config. Fixing the config won't retry the migration. Can you address this issue? Potentially distinguish read/parse failures from empty valid configs and add regression tests to cover these scenarios.

…ed config Distinguish read/parse failures from empty valid configs so a transient file error or JSONC syntax error does not permanently mark the migration as done. Fixing the file now correctly retries.

…sion-remigration

johnnyeric · 2026-08-28T12:20:35Z

+        continue
+      }
+      const errors: ParseError[] = []
+      const data = (parseJsonc(text, errors) as Record<string, unknown> | undefined) ?? {}


Thanks for addressing the comment, the change looks good, but please pass { allowTrailingComma: true } here to match ConfigParse.jsonc. Otherwise valid configs with trailing commas are treated as malformed and never receive the compatibility migration. Please add a regression test for that case.

Pass { allowTrailingComma: true } to match ConfigParse.jsonc so valid JSONC with trailing commas is not treated as malformed and correctly receives the compatibility migration. Add regression test for trailing-comma config.

johnnyeric · 2026-09-01T13:26:45Z

Thanks @noobezlol, I was able to reproduce the fix. Merged.

fix(cli): remember bash permission migration

c6acd28

noobezlol marked this pull request as ready for review July 29, 2026 11:07

kilo-code-bot Bot reviewed Jul 29, 2026

View reviewed changes

noobezlol added 3 commits July 29, 2026 16:57

docs(cli): explain bash migration marker

eadd2d3

Merge remote-tracking branch 'origin/main' into agent/fix-bash-permis…

f6ad289

…sion-remigration

Merge remote-tracking branch 'origin/main' into agent/fix-bash-permis…

73b6d29

…sion-remigration # Conflicts: # packages/opencode/src/kilocode/config/config.ts

johnnyeric requested changes Aug 27, 2026

View reviewed changes

noobezlol added 2 commits August 27, 2026 17:33

fix(cli): retry bash permission migration after unreadable or malform…

abbeb3a

…ed config Distinguish read/parse failures from empty valid configs so a transient file error or JSONC syntax error does not permanently mark the migration as done. Fixing the file now correctly retries.

Merge remote-tracking branch 'origin/main' into agent/fix-bash-permis…

a93225b

…sion-remigration

johnnyeric reviewed Aug 28, 2026

View reviewed changes

fix(cli): handle trailing commas in bash permission migration

0330e40

Pass { allowTrailingComma: true } to match ConfigParse.jsonc so valid JSONC with trailing commas is not treated as malformed and correctly receives the compatibility migration. Add regression test for trailing-comma config.

johnnyeric approved these changes Sep 1, 2026

View reviewed changes

johnnyeric merged commit 95c731e into Kilo-Org:main Sep 1, 2026
45 of 48 checks passed

kilo-maintainer Bot mentioned this pull request Sep 1, 2026

release(jetbrains): v7.1.4 #13677

Merged

github-actions Bot mentioned this pull request Sep 2, 2026

docs: auto-sync with merged PRs (through 2026-09-02) #13572

Open

dyoshikawa mentioned this pull request Sep 8, 2026

Follow up Kilo Code upstream updates: mode-specific rule directories (.kilo/rules-{mode}/) not authorable dyoshikawa/rulesync#2499

Open

Navigation Menu

Uh oh!

fix(cli): remember bash permission migration - #12642

fix(cli): remember bash permission migration#12642
johnnyeric merged 7 commits into
Kilo-Org:mainfrom
noobezlol:agent/fix-bash-permission-remigration

noobezlol commented Jul 29, 2026

Uh oh!

kilo-code-bot Bot Jul 29, 2026

Uh oh!

kilo-code-bot Bot commented Jul 29, 2026 •

edited

Loading

Previous review (commit `abbeb3a`)

Previous review (commit `c6acd28`)

Overview

SUGGESTION

Uh oh!

johnnyeric Aug 27, 2026

Uh oh!

johnnyeric Aug 28, 2026

Uh oh!

Uh oh!

johnnyeric commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -344,13 +345,20 @@ export namespace KilocodeConfig {
		* behavior now that the new default is `bash: "ask"`.

Uh oh!

Conversation

noobezlol commented Jul 29, 2026

Issue

Context

Implementation

Screenshots / Video

How to Test

Reviewer test steps

Checklist

Uh oh!

kilo-code-bot Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Previous review (commit abbeb3a)

Previous review (commit c6acd28)

Overview

SUGGESTION

Uh oh!

johnnyeric Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

johnnyeric Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

johnnyeric commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kilo-code-bot Bot commented Jul 29, 2026 •

edited

Loading

Previous review (commit `abbeb3a`)

Previous review (commit `c6acd28`)