Skip to content

fix(gateway): optimistically assume tools support when supported_parameters is missing #12426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrarnoldus merged 3 commits into from
Jul 21, 2026
Merged

fix(gateway): optimistically assume tools support when supported_parameters is missing #12426

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e944a57
fix(gateway): optimistically assume tools support when supported_para…
chrarnoldus Jul 21, 2026
b692d03
fix(gateway): also optimistically set tool_call for models with missi…
chrarnoldus Jul 21, 2026
f3905fb
Merge branch 'main' into fix/gateway-optimistic-tools-support
chrarnoldus Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/kilo-gateway/src/api/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ export async function fetchKiloModels(options?: {
const models: Record<string, any> = {}

for (const model of raw.data) {
// Skip models that don't support tools — Kilo requires tool calling
if (!model.supported_parameters?.includes("tools")) {
// Skip models that explicitly don't support tools — Kilo requires tool calling
// Optimistically assume models with a missing supported_parameters array support tools
if (model.supported_parameters && !model.supported_parameters.includes("tools")) {

@kilo-code-bot kilo-code-bot Bot Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: tool_call still resolves to false for optimistically-included models

This filter now lets models with a missing supported_parameters array through, but transformToModelDevFormat (models.ts:216) does const supportedParameters = model.supported_parameters || [], then supportsTools = supportedParameters.includes("tools") (models.ts:226). For a model with no supported_parameters, that evaluates to [], so supportsTools is false and the resulting model gets tool_call: false — directly contradicting the stated intent of "optimistically assume ... support tools". Consumers that gate tool usage on tool_call will still treat these models as non-tool-capable, so the fix doesn't fully achieve its goal. Consider deriving supportsTools the same way as this filter, e.g. !model.supported_parameters || supportedParameters.includes("tools").

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@chrarnoldus chrarnoldus Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't seem to matter

continue
}

Expand Down
Loading