fix(gateway): optimistically assume tools support when supported_parameters is missing - #12426
Conversation
…meters is missing Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
| if (!model.supported_parameters?.includes("tools")) { | ||
| // Skip models that explicitly don't support tools — Kilo requires tool calling | ||
| // Optimistically assume models with a missing supported_parameters array support tools | ||
| if (model.supported_parameters && !model.supported_parameters.includes("tools")) { |
There was a problem hiding this comment.
WARNING: tool_call still resolves to false for optimistically-included models
This filter now lets models with a missing supported_parameters array through, but transformToModelDevFormat (models.ts:216) does const supportedParameters = model.supported_parameters || [], then supportsTools = supportedParameters.includes("tools") (models.ts:226). For a model with no supported_parameters, that evaluates to [], so supportsTools is false and the resulting model gets tool_call: false — directly contradicting the stated intent of "optimistically assume ... support tools". Consumers that gate tool usage on tool_call will still treat these models as non-tool-capable, so the fix doesn't fully achieve its goal. Consider deriving supportsTools the same way as this filter, e.g. !model.supported_parameters || supportedParameters.includes("tools").
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
There was a problem hiding this comment.
it doesn't seem to matter
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The follow-up commit fixes the previously flagged issue: Files Reviewed (1 file)
Previous Review Summary (commit e944a57)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e944a57)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
Reviewed by claude-sonnet-5 · Input: 22 · Output: 3.5K · Cached: 426K Review guidance: REVIEW.md from base branch |
…ng supported_parameters Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
…c-tools-support fix(gateway): optimistically assume tools support when supported_parameters is missing
Models with a missing
supported_parametersarray are now optimistically assumed to support tools, instead of being filtered out. Only models that explicitly list parameters withouttoolsare skipped.