Skip to content

feat(vscode): animate tool call previews - #11486

Closed
Drixled wants to merge 2 commits into
mainfrom
feat/vscode-tool-detail-motion
Closed

feat(vscode): animate tool call previews#11486
Drixled wants to merge 2 commits into
mainfrom
feat/vscode-tool-detail-motion

Conversation

@Drixled

@Drixled Drixled commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

What

Add consistent accordion-style open and close motion to VS Code tool-call and reasoning details.

Why

Tool previews polished in #11146 still expanded abruptly and inconsistently. The new grid-track motion follows asynchronously rendered Markdown, highlighting, and diffs without animating to a stale measured height, retains deferred details through collapse, preserves full-width output surfaces, and respects reduced-motion preferences. It avoids the JavaScript auto-height path that caused the shell rendering regression fixed in #11402.

Comment thread packages/ui/src/components/basic-tool.tsx
@kilo-code-bot

kilo-code-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • .changeset/animate-tool-card-reveals.md
  • packages/kilo-ui/src/components/basic-tool.css
  • packages/kilo-ui/src/components/basic-tool.tsx
  • packages/kilo-ui/src/components/message-part.css
  • packages/kilo-ui/src/components/message-part.tsx
  • packages/ui/src/components/basic-tool.tsx
Previous Review Summary (commit f47c8c3)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit f47c8c3)

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
packages/ui/src/components/basic-tool.tsx 129 Collapsed deferred diff/code panes now stay mounted after close, which can grow memory usage over long sessions.
Files Reviewed (6 files)
  • .changeset/animate-tool-card-reveals.md - 0 issues
  • packages/kilo-ui/src/components/basic-tool.css - 0 issues
  • packages/kilo-ui/src/components/basic-tool.tsx - 0 issues
  • packages/kilo-ui/src/components/message-part.css - 0 issues
  • packages/kilo-ui/src/components/message-part.tsx - 0 issues
  • packages/ui/src/components/basic-tool.tsx - 1 issue

Reviewed by gpt-5.4-20260305 · Input: 49.8K · Output: 6K · Cached: 123.4K

Review guidance: REVIEW.md from base branch main

@Drixled Drixled closed this Jun 19, 2026
@Drixled
Drixled deleted the feat/vscode-tool-detail-motion branch June 19, 2026 22:51
@Drixled Drixled changed the title feat(vscode): animate expandable tool details feat(vscode): animate tool call previews Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant