Polish VS Code tool call previews - #11146
Conversation
| ) | ||
| } | ||
|
|
||
| function BashHighlightedOutput(props: { cmd: string; output: string; outputPath?: string; active?: boolean }) { |
There was a problem hiding this comment.
SUGGESTION: Dead active prop — now unused after removing the deferredHighlight effects
The active?: boolean prop was used by the removed createEffect blocks to gate deferred syntax highlighting. The prop is still declared in the signature and passed at the call site (active={open()}), but nothing inside the function body reads props.active any more. The call site can stop passing it and the signature can drop it to avoid misleading future readers.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (incremental diff, 20+ files)
Resolved IssueThe previous Previous Review Summaries (4 snapshots, latest commit a5f2a84)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit a5f2a84)Status: No Issues Found | Recommendation: Merge Files Reviewed (30+ files)
Previous review (commit 2d46adb)Status: No Issues Found | Recommendation: Merge Changes Since Last ReviewThe incremental commits beyond
Previous Finding Resolved
Areas Verified
Files Reviewed (40+ files from incremental diff)
Fix these issues in Kilo Cloud Previous review (commit 0aaef83)Status: No Issues Found | Recommendation: Merge Changes Since Last ReviewThe incremental commits beyond Additional changes in the new commits:
Previous Finding Resolved
Files Reviewed (34 files)
Fix these issues in Kilo Cloud Previous review (commit f8ee07f)Status: No Issues Found | Recommendation: Merge Changes Since Last ReviewThe new commits extend the VS Code tool-call polish work with:
All code changes are clean. The one notable pattern to be aware of: Observation: cross-package relative import in Storybook story
Files Reviewed (incremental, 9 files)
Previous observations (resolved)
Reviewed by deepseek-v4-pro-20260423 · 1,232,895 tokens Review guidance: REVIEW.md from base branch |
|
@Drixled The edit tools (Edit, Write and Patch) have an option for "Open in Diff Viewer" on the right side - Can you please check the feature is still there? Note: I can only see the patch tool being used with GPT models |
|
@imanolmzd-svg yup, I manually tested it, they’re still there.
|
Polish VS Code tool call previews


Summary
Detailed list of changes:
Shell tool:
Other previews:
Notes