-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(cli): import cloud sessions before validation #11223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
catrielmuller
merged 4 commits into
Kilo-Org:main
from
maphew:fix/cli-cloud-fork-session-import
Jul 6, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4104ab5
fix(cli): import cloud sessions before validation
maphew fff95d3
Merge branch 'main' into fix/cli-cloud-fork-session-import
maphew 1d9dc6a
Merge branch 'main' into fix/cli-cloud-fork-session-import
maphew 10951d6
Merge remote-tracking branch 'origin/main' into fix/cli-cloud-fork-se…
catrielmuller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@kilocode/cli": patch | ||
| --- | ||
|
|
||
| Fix cloud session fork commands so they import cloud sessions before validating the local session. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING:
expectinside mock will be silently swallowedThe
expect(input.sessionId).toBe("ses_cloud")assertion sits inside the mockedimportfunction. WhenimportCloudSessionis called, it invokes this mock — but the call site wraps the whole thing with.catch(() => undefined)(seethread.tsline 38). If this assertion throws (e.g. the wrong session ID is passed), the error is caught andidbecomesundefined, causing an early return withfork.ok = false. The test then only fails on the laterexpect(seen).toEqual(["ses_local"])with a confusing message rather than pointing directly at the bad session ID.Consider moving the assertion out of the mock and instead capturing the received
sessionIdin a variable, then asserting after theawait:Reply with
@kilocode-bot fix itto have Kilo Code address this issue.