fix(cli): import cloud sessions before validation

[maphew]

Summary

• Import --cloud-fork sessions before validating the local session ID in TUI startup.
• Apply the same ordering to daemon-backed TUI attach so validation uses the imported local session ID.
• Add regression coverage and a patch changeset for the CLI fix.

Fixes #11222

Signed-off-by: gpt-5.5 on behalf of matt

[kilo-code-bot]

WARNING: expect inside mock will be silently swallowed

The expect(input.sessionId).toBe("ses_cloud") assertion sits inside the mocked import function. When importCloudSession is called, it invokes this mock — but the call site wraps the whole thing with .catch(() => undefined) (see thread.ts line 38). If this assertion throws (e.g. the wrong session ID is passed), the error is caught and id becomes undefined, causing an early return with fork.ok = false. The test then only fails on the later expect(seen).toEqual(["ses_local"]) with a confusing message rather than pointing directly at the bad session ID.

Consider moving the assertion out of the mock and instead capturing the received sessionId in a variable, then asserting after the await:

let importedId: string | undefined
mock.module("@kilocode/sdk/v2", () => ({
  createKiloClient: () => ({
    kilo: {
      cloud: {
        session: {
          import: async (input: { sessionId: string }) => {
            importedId = input.sessionId
            return { data: { id: "ses_local" } }
          },
        },
      },
    },
  }),
}))
// ... after `await mod.KiloTuiThreadDaemon.attach(...)`
expect(importedId).toBe("ses_cloud")

---

_{Reply with @kilocode-bot fix it to have Kilo Code address this issue.}

[kilo-code-bot]

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
packages/opencode/test/kilocode/cli/tui/thread.test.ts	34	expect inside mock is wrapped by .catch(() => undefined) — assertion failure is silently swallowed, test would fail with a misleading message on the later expect(seen) check

Other Observations (not in diff)

Mock-heavy test: The new test uses 5 mock.module calls. The AGENTS.md guide discourages heavy mocking. In this case the mocks appear necessary given the depth of integration (daemon client, SDK, TUI config), so this is a judgment call rather than a hard violation. Consider whether importCloudSession from @/kilocode/cloud-session (which is NOT mocked) could be stubbed at a higher level in a future refactor to reduce the mock surface.

process.exitCode = 1 side-effect in session() helper: packages/opencode/src/kilocode/cli/cmd/tui/thread.ts line 42 mutates process.exitCode on failure. The test doesn't verify this side-effect is absent on the success path; this is a pre-existing pattern and not introduced by this PR, but worth keeping in mind if test isolation becomes a concern later.

Files Reviewed (4 files)

• .changeset/cloud-fork-session-import.md — changeset looks good, user-facing description is clear
• packages/opencode/src/cli/cmd/tui/thread.ts — fix is correct; validateSession now runs after cloud import, using the local session ID
• packages/opencode/src/kilocode/cli/cmd/tui/thread.ts — daemon path fix is correct; session() called before validateSession, fork.id passed through consistently
• packages/opencode/test/kilocode/cli/tui/thread.test.ts — 1 issue (see above)

Fix these issues in Kilo Cloud

---

_{Reviewed by claude-4.6-sonnet-20260217 · 676,008 tokens}

_{Review guidance: REVIEW.md from base branch main}

[maphew]

thanks!