Skip to content

fix(vscode): count pending submission time - #11113

Merged
marius-kilocode merged 1 commit into
mainfrom
fix/local-prompt-elapsed
Jun 16, 2026
Merged

fix(vscode): count pending submission time#11113
marius-kilocode merged 1 commit into
mainfrom
fix/local-prompt-elapsed

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

#11103 makes the first prompt and Thinking spinner appear immediately in a new Agent Manager Local tab. While that tab is still waiting for the backend to create its real session, however, the backend status remains idle. The elapsed indicator interpreted that idle status as inactive, so users could see a spinner with no timer for several seconds, followed by the timer suddenly appearing at a higher value once session creation finished.

Treat a pending submission as active for elapsed-time tracking. The timer now progresses visibly from the moment the prompt is sent and continues from the same start time when the pending tab is promoted to a real session, rather than appearing late or resetting during the handoff.

Follow-up to #11103 (comment)

@kilo-code-bot

kilo-code-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The fix is correct and well-scoped. The extracted tracksElapsed predicate cleanly captures the two-phase logic: keep the timer alive while a draft submission is pending (before a backend session ID exists), then defer to backend status once the session is promoted. The type predicate return type (since is number) is a nice touch — it narrows the type for the caller.

Tests cover all four meaningful cases (pending-only, each active backend status, idle-with-no-pending, missing since) without duplicating implementation logic.

Files Reviewed (3 files)
  • packages/kilo-vscode/webview-ui/src/components/shared/working-indicator-utils.ts
  • packages/kilo-vscode/webview-ui/src/components/shared/WorkingIndicator.tsx
  • packages/kilo-vscode/tests/unit/working-indicator.test.ts

Fix these issues in Kilo Cloud


Reviewed by claude-4.6-sonnet-20260217 · 636,092 tokens

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 5561d90 into main Jun 16, 2026
20 checks passed
@marius-kilocode
marius-kilocode deleted the fix/local-prompt-elapsed branch June 16, 2026 09:15
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants