fix(agent-manager): show local prompt feedback immediately - #11103
Conversation
| return ( | ||
| <div class="working-indicator-slot"> | ||
| <Show when={session.status() !== "idle" && !blocked()}> | ||
| <Show when={session.submitting() || (session.status() !== "idle" && !blocked())}> |
There was a problem hiding this comment.
SUGGESTION: Elapsed timer won't count during the draft-submission phase
The elapsed createEffect at line 22–38 gates itself on status === 'idle' || !since (line 26). When submitting() is true but no real session has been created yet, status() reads only currentSessionID() (not the draftSessionID fallback), so it returns 'idle' and the timer short-circuits immediately. The spinner will show (submitting() === true) but the elapsed counter stays at 0s.
This is a minor cosmetic gap rather than a logic bug — the busySince timestamp is correctly set via startSubmission — but users will see the spinner appear without the elapsed timer counting until the backend session is created and the status transitions away from 'idle'.
Consider updating the createEffect guard to also continue when submitting() is true:
if ((status === 'idle' && !session.submitting()) || !since) {
setElapsed(0)
return
}
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Other Observations (not in diff)
The
As noted in the inline comment: Files Reviewed (7 files)
Fix these issues in Kilo Cloud Reviewed by claude-4.6-sonnet-20260217 · 1,222,162 tokens Review guidance: REVIEW.md from base branch |
…11103) * fix(agent-manager): show initial prompt feedback immediately * chore: update kilo-vscode visual regression baselines --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The OpenCode v1.14.48 integration in #10996 made cold session creation slow enough to expose a gap in Agent Manager's Local tab state: the first prompt cleared the composer, but the transcript and progress indicator waited for the backend to create the real session. This left the UI appearing unresponsive for several seconds.
Render the prompt and submission progress against the pending Local session immediately, then transfer that optimistic state to the real session when creation completes. The handoff uses the originating draft ID so background session creation cannot replace or focus the wrong tab, and failed submissions clean up the pending state.