Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/prevent-subagent-questions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@kilocode/cli": patch
"kilo-code": patch
---

Prevent task subagents from asking questions that users cannot answer from the parent session.
6 changes: 5 additions & 1 deletion packages/opencode/src/kilocode/tool/task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ export namespace KiloTask {

/** Extra permission rules appended to subagent sessions */
export function permissions(rules: Permission.Ruleset): Permission.Ruleset {
return [{ permission: "task", pattern: "*", action: "deny" }, ...rules]
return [
{ permission: "task", pattern: "*", action: "deny" },
{ permission: "question", pattern: "*", action: "deny" },
...rules,
]
}

export function merge(...rulesets: Permission.Ruleset[]): Permission.Ruleset {
Expand Down
1 change: 1 addition & 0 deletions packages/opencode/src/tool/task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ export const TaskTool = Tool.define(
variant, // kilocode_change
agent: next.name,
tools: {
question: false, // kilocode_change - subagents cannot prompt the user directly
...(canTodo ? {} : { todowrite: false }),
...(canTask ? {} : { task: false }),
...Object.fromEntries((cfg.experimental?.primary_tools ?? []).map((item) => [item, false])),
Expand Down
9 changes: 8 additions & 1 deletion packages/opencode/test/kilocode/task-nesting.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ describe("Kilo task nesting", () => {
),
)

it.live("disables nested task tool even when global task permission allows it", () =>
it.live("disables nested task and question tools even when global permissions allow them", () =>
provideTmpdirInstance(
() =>
Effect.gen(function* () {
Expand Down Expand Up @@ -186,20 +186,27 @@ describe("Kilo task nesting", () => {

const child = yield* sessions.get(result.metadata.sessionId)
expect(seen?.tools?.task).toBe(false)
expect(seen?.tools?.question).toBe(false)
expect(child.permission).toEqual(
expect.arrayContaining([
{
permission: "task",
pattern: "*",
action: "deny",
},
{
permission: "question",
pattern: "*",
action: "deny",
},
]),
)
}),
{
config: {
permission: {
task: "allow",
question: "allow",
},
},
},
Expand Down
1 change: 1 addition & 0 deletions packages/opencode/test/tool/task.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,7 @@ describe("tool.task", () => {
)
// kilocode_change end
expect(seen?.tools).toEqual({
question: false, // kilocode_change - subagents cannot prompt the user directly
todowrite: false,
task: false, // kilocode_change - Kilo disallows nested subagents
bash: false,
Expand Down
Loading