fix(cli): prevent subagents asking questions - #11101
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The fix is well-structured. Two layers of defence are applied:
The Test coverage in both Files Reviewed (5 files)
Reviewed by claude-4.6-sonnet-20260217 · 1,019,718 tokens Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge (squash)
June 11, 2026 09:53
johnnyeric
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task subagents can inherit or be configured with access to the interactive question tool, but those questions belong to the child session and are not reliably answerable from the parent conversation. This leaves the child task waiting indefinitely in both the VS Code sidebar and Agent Manager.
Disable the question tool at the task-spawn boundary and persist a matching deny rule on child sessions. Applying the restriction after configured agent permissions ensures global and custom-agent overrides cannot re-enable interactive questions for task subagents, while primary sessions retain normal question support.