Repository navigation
Conversation
…kwf explorer-home-ar-rtl-arabic-labels-in-the-tracked-eyebrow-60e9e-13a6/s1)
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryNo changed lines to review: the branch was reset so the PR head tree ( Files Reviewed (0 files)
Previous Review Summary (commit 60c22b4)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 60c22b4)Status: No Issues Found | Recommendation: Merge Executive SummaryThe joined-script letter-spacing reset in the shared Files Reviewed (7 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
…-tracked-eyebrow-60e9e-13a6
The branch had dropped main's 0254-0257 migrations, so its journal stopped at idx 253 while main was at 259. That is not a migration this PR authored: the branch changes no schema and its packages/db/src/schema.ts matches main. Merge origin/main and take main's migration folder verbatim. The drizzle CLI then reports "No schema changes, nothing to migrate", so no migration is generated and none of main's migrations remain dropped. Guards: the packages/db jest suite passes (7 suites, 34 tests), including migration-journal.test.ts.
Status: superseded — this PR contains no changesThe PR head tree is identical to the PR base tree, so GitHub reports 0 changed files. Evidence:
The behaviour this PR describes is already in
CI at head Not run, by instruction: local tests, builds and device E2E. No new screenshot proof is added. Note on this branch: I pushed Recommendation: close this PR as superseded, or state which behaviour is still missing from |
Changelog for users
Changelog for maintainers
Textcomponent adds an inlineletterSpacing: 0when its own string children contain a joined script, and keeps the RTL paragraph direction.tracking-*className while the className stays on the element.styleis merged last, so an explicit caller letter spacing still wins.containsJoinedScript,textLetterSpacingandNATURAL_LETTER_SPACINGlive inapps/mobile/src/lib/rtl-text.ts; the range covers Arabic, Arabic Supplement, Arabic Extended-A and both Arabic Presentation Forms.Textrun applies its own reset.[direction, undefined]to[direction].E2E proof
Owner request
Open findings (not fixed here)
VERDICT {"verdict":"passed","scenarios":[{"name":"e1","result":"pass","evidence":"evidence/e1-scene.log","note":"ios: e1-scene.log shows the Arabic Home digest with the three label groups '\u0627\u0644\u062c\u0644\u0633\u0627\u062a \u0627\u0644\u062c\u0627\u0631\u064a\u0629 \u0627\u