Repository navigation
fix(mobile): stop Latin letter spacing from breaking RTL Arabic labels - #6440
Merged
iscekic merged 1 commit intoSep 22, 2026
Conversation
Explorer finding: home-ar: The Arabic labels — the top 'الجلسات الجارية الآن' / 'عرض الكل' row, the 'استكشف' eyebrow and the bottom tab labels — are rendered with Latin letter-spacing, so the cursive glyphs are visibly disconnected ('ا س ت ك ش ف').
The user-agent explorer found this while using the app like a user.
One finding per item; the explorer never edits product code.
Flow: home-ar
Found on revision: fb5e67d
Repro:
1. set this state first: credits 40; reviews 6
2. open the app on 1B2CEF92-949B-4331-A6F5-FAD734645205
3. reach home-ar
4. the capture shows the defect named below
Observed: The Arabic labels — the top 'الجلسات الجارية الآن' / 'عرض الكل' row, the 'استكشف' eyebrow and the bottom tab labels — are rendered with Latin letter-spacing, so the cursive glyphs are visibly disconnected ('ا س ت ك ش ف').
Expected: the screen renders without this defect
Evidence (from the device run):
- ~/.local/share/kwf/findings/explorer-home-ar-the-arabic-labels-the-top-row-the-eyebro-69c8a089/home-ar.png
iscekic
marked this pull request as draft
September 20, 2026 21:10
iscekic
marked this pull request as ready for review
September 20, 2026 21:23
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe RTL letter-spacing reset is correctly ordered before the caller style in the shared Files Reviewed (6 files)
Reviewed by efficient · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
Collaborator
Author
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
eshurakov
approved these changes
Sep 21, 2026
eshurakov
left a comment
Contributor
There was a problem hiding this comment.
Approved after a shallow triage pass. No blocking findings.
iscekic
deleted the
kwf/explorer-home-ar-the-arabic-labels-the-top-row-the-eyebro-69c8a-fabd
branch
September 22, 2026 01:08
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
Textcomponent prependsletterSpacing: 0to its RTL style array, ahead of any caller style.RTL_NO_LETTER_SPACINGinlib/rtl-text.tsholds the reset, so text built withcreateElementcan reuse it.Textin RTL, includingtracking-tightheadings; check headings still look correct.tracking-*classes stay inclassName; only their RTL rendering is neutralized, so the LTR design is untouched.Textcomponent and the new mounted tracking test.Kilo Code Reviewcheck needed no product change: it is the review bot's own check run, and it reported no findings.E2E proof
Owner request
E2E proof — log excerpts