-
Notifications
You must be signed in to change notification settings - Fork 11
Add per-repository overrides for enabling PR's #6028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+101
−3
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Merge-commit synchronizes skip this toggle and can keep an in-flight review alive
Step 4 returns early for merge-commit
synchronizeevents (e.g. GitHub "Update branch") before this check runs. Bot-authored PRs already compute their skip up front so that path cannot preserve a review the guardrail is meant to drop;prReviewMode === 'off'needs the same treatment.If reviews are toggled off while a review is in flight and the next webhook is a merge-commit synchronize,
migrateInFlightReviewsToMergeCommitHeadre-points the review and opens a fresh check run instead of cancelling it.Resolve
prReviewModebefore step 4 and treat'off'likeisBotPullRequestSkipso those events fall through to supersession and this skip.Reply with
@kilocode-bot fix itto have Kilo Code address this issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a deliberate trade-off. If you do it the other way, then an old PR review would block any accepts until the reaping later.
TL;DR: If you toggle the setting mid-PR continuing any existing PR's is better than abandoning them