Add per-repository overrides for enabling PR's - #6028
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| ); | ||
| const { prReviewMode } = resolveRepositorySettings(integration, repositoryCustomization); | ||
|
|
||
| if (prReviewMode === 'off') { |
There was a problem hiding this comment.
WARNING: Merge-commit synchronizes skip this toggle and can keep an in-flight review alive
Step 4 returns early for merge-commit synchronize events (e.g. GitHub "Update branch") before this check runs. Bot-authored PRs already compute their skip up front so that path cannot preserve a review the guardrail is meant to drop; prReviewMode === 'off' needs the same treatment.
If reviews are toggled off while a review is in flight and the next webhook is a merge-commit synchronize, migrateInFlightReviewsToMergeCommitHead re-points the review and opens a fresh check run instead of cancelling it.
Resolve prReviewMode before step 4 and treat 'off' like isBotPullRequestSkip so those events fall through to supersession and this skip.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
There was a problem hiding this comment.
This was a deliberate trade-off. If you do it the other way, then an old PR review would block any accepts until the reaping later.
TL;DR: If you toggle the setting mid-PR continuing any existing PR's is better than abandoning them
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Reviewed by grok-4.6 · Input: 140.9K · Output: 19.4K · Cached: 216.8K Review guidance: REVIEW.md from base branch |
2 participants
Summary
If the user toggles off PR reviews for a specific repository, detect this during the incoming webhook and drop the request
Verification
Will test end-to-end in production after merging