Skip to content

fix(mobile): count grep/glob badge from sheet rows #5315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iscekic merged 1 commit into from
Aug 18, 2026
Merged

fix(mobile): count grep/glob badge from sheet rows #5315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions apps/mobile/src/components/agents/tool-card-display.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,40 @@ describe('getToolDisplay badge rules', () => {
).toBeUndefined();
expect(getDisplay(makeToolPart('grep', running({ pattern: 'foo' }))).badge).toBeUndefined();
});

it('counts grep sheet rows, not the Found caption', () => {
expect(
getDisplay(
makeToolPart('grep', completed({ pattern: 'x' }, 'Found 1 match\nsrc/a.ts:\n Line 1: x'))
).badge
).toBe('2 matches');
});

it('omits the grep badge when only a Found caption exists', () => {
expect(
getDisplay(makeToolPart('grep', completed({ pattern: 'x' }, 'Found 1 match'))).badge
).toBeUndefined();
});

it('counts glob sheet rows, not the Found caption', () => {
expect(
getDisplay(
makeToolPart(
'glob',
completed(
{ pattern: 'src/**/*.ts' },
'Found 2 file(s) matching "src/**/*.ts":\nsrc/a.ts\nsrc/b.ts'
)
)
).badge
).toBe('2 files');
});

it('omits the glob badge when only a Found caption exists', () => {
expect(
getDisplay(makeToolPart('glob', completed({ pattern: 'src/**/*.ts' }, 'Found 1 file'))).badge
).toBeUndefined();
});
});

describe('toolPartHasDetails', () => {
Expand Down
17 changes: 8 additions & 9 deletions apps/mobile/src/components/agents/tool-card-display.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,16 @@ import {
truncateText,
} from './tool-card-utils';
import { listPatchFilePaths } from './tool-patch-model';
import { buildResultRowsModel } from './tool-list-model';

export type ToolDisplay = {
title: string;
subtitle?: string;
badge?: string;
};

function countOutputLines(output: string): number {
if (output.length === 0) {
return 0;
}
return output.split('\n').filter(line => line.trim().length > 0).length;
function countResultRows(output: string, kind: 'grep' | 'glob'): number {
return buildResultRowsModel(output, kind).rows.length;
}

/**
Expand Down Expand Up @@ -65,8 +63,8 @@ export function getToolDisplay(part: ToolPart): ToolDisplay {
case 'glob': {
const pattern = typeof input.pattern === 'string' ? input.pattern : '';
const output = status === 'completed' ? part.state.output : undefined;
const matchCount = output ? countOutputLines(output) : undefined;
const badge = matchCount !== undefined ? `${matchCount} files` : undefined;
const matchCount = output ? countResultRows(output, 'glob') : undefined;
const badge = matchCount !== undefined && matchCount > 0 ? `${matchCount} files` : undefined;
return { title: 'glob', subtitle: pattern || 'glob', badge };
}
case 'grep': {
Expand All @@ -77,8 +75,9 @@ export function getToolDisplay(part: ToolPart): ToolDisplay {
subtitle += ` (${include})`;
}
const output = status === 'completed' ? part.state.output : undefined;
const matchCount = output ? countOutputLines(output) : undefined;
const badge = matchCount !== undefined ? `${matchCount} matches` : undefined;
const matchCount = output ? countResultRows(output, 'grep') : undefined;
const badge =
matchCount !== undefined && matchCount > 0 ? `${matchCount} matches` : undefined;
return { title: 'grep', subtitle, badge };
}
case 'list': {
Expand Down