fix(mobile): count grep/glob badge from sheet rows - #5315
Merged
Conversation
Use buildResultRowsModel so the Found caption is not a match or a file.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Reviewed the grep/glob badge fix at HEAD Files Reviewed (2 files)
Reviewed by kimi-k3 · Input: 85.6K · Output: 2.7K · Cached: 175.1K Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found Nsummary and no files no longer shows a misleading1 matchesbadge.getToolDisplaynow derives the badge frombuildResultRowsModel(output, kind).rows.lengthinstead of a raw non-empty-line count, so the liftedFound Ncaption is not counted. The badge is omitted when the model has zero rows.Verification
pnpm --filter kilo-app exec vitest run src/components/agents/tool-card-display.test.ts(36 tests pass),pnpm --filter kilo-app typecheck,pnpm --filter kilo-app lint.Visual Changes
N/A
Reviewer Notes