Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce asynchronous stuff to resolve flickering #1951

Merged
merged 1 commit into from
Nov 14, 2024

Commits on Nov 13, 2024

  1. fix: reduce asynchronous stuff to resolve flickering

    In this commit, we introduce a slightly smarter approach to handling custom module registration
    and executing the `beforeRender` function. The current issue is that the `quill-editor-toolbar`
    may be projected before the editor is rendered due to the `Promise.all` in `mergeMap`.
    This is noticeable on slower devices, where the toolbar appears first (without styles),
    and then after a microtask delay, Quill is created.
    
    Switching to observables resolves this issue because observables can emit both synchronously and
    asynchronously, and most observables can cache their emissions using `shareReplay`,
    ensuring that subsequent emissions are always synchronous.
    arturovt committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    6345ee6 View commit details
    Browse the repository at this point in the history