Repository navigation
fix: use @kikobeats/got to support Node.js 24.20 - #25
Conversation
got@11 is unmaintained and breaks on Node.js 24.20 (nodejs/node#64847): a retried connection error rejects with ERR_SOCKET_CLOSED_BEFORE_CONNECTION and then crashes the process with uncaught exceptions. @kikobeats/got is got@11 with that fix backported. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe project replaces ChangesHTTP client dependency update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The dependency and installation changes introduce no established merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fec63fe. Configure here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC
pnpm 12 fails the install when a package with a build script is not approved, and CI hits it through the implicit install that precedes every script: Error: ERR_PNPM_IGNORED_BUILDS Ignored build scripts: simple-git-hooks@2.14.0, spawn-sync@1.0.15 pnpm 12 reads the approval from allowBuilds in pnpm-workspace.yaml. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC

got@11is unmaintained and crashes on Node.js 24.20+ (nodejs/node#64847): a retried connection error rejects withERR_SOCKET_CLOSED_BEFORE_CONNECTIONand then throws uncaught exceptions, killing the process.@kikobeats/gotisgot@11.8.6with that fix backported (upstream declined a v11 release), plus fixes forstream.pipeline(), thecacheoption and uploads on modern Node.js.Changes
package.json:got→@kikobeats/got ~11.8.8require("got")→require("@kikobeats/got")The API is identical:
@kikobeats/gotis the samegot@11with fixes, so no call sites change.Testing
Suite run on Node.js 24.20.0 (CI
lts/*) and 24.16.0, plusstandard.🤖 Generated with Claude Code
https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC
Note
Medium Risk
Swaps the HTTP client used for all URL fetches; behavior should match
got@11, but any fork divergence could affect content-length resolution in production.Overview
Replaces the unmaintained
gotdependency with@kikobeats/got(~11.8.8) inpackage.json,src/index.js, andtest/index.jsso HTTP streaming for URL-based content-length checks works on Node.js 24.20+ without theERR_SOCKET_CLOSED_BEFORE_CONNECTIONcrash. The public API is unchanged—only therequiretarget and a one-line formatting tweak infromHeaders.Adds
pnpm-workspace.yamlwithallowBuildsforsimple-git-hooksandspawn-sync, and extends.gitignoreto ignoreinstall.logandpnpm-lock.yaml.Reviewed by Cursor Bugbot for commit e80f409. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Refactor
Tests
Chores