Skip to content

Conversation

@aelovikov-intel
Copy link
Contributor

Spec changes are at KhronosGroup/SYCL-Docs#674.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner February 26, 2025 00:51
@bader bader requested a review from a team February 26, 2025 00:57
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aelovikov-intel
Copy link
Contributor Author

KhronosGroup/SYCL-Docs#674 hasn't been merged yet, and no implementation has implemented it yet (to the best of my knowledge). I do have a bunch of local changes implementing that and other vec/swizzle changes in DPCPP though.

My current plan is to merge those local change for which the spec PR have been merged already. Once done, I'll return to the byte changes and will update this PR with "expected failures" for implementation that won't have byte changes implemented by that time.

@tomdeakin
Copy link
Contributor

KhronosGroup/SYCL-Docs#674 is blocked by this PR.

@tomdeakin
Copy link
Contributor

Awaiting implementation.

@aelovikov-intel
Copy link
Contributor Author

This is blocked by KhronosGroup/SYCL-Docs#800 because I need it to enable new vec/swizzle implementation in https://github.com/intel/llvm by default (in preview mode).

@tomdeakin
Copy link
Contributor

KhronosGroup/SYCL-Docs#800 is now merged.

@aelovikov-intel
Copy link
Contributor Author

KhronosGroup/SYCL-Docs#800 is now merged.

I've implemented the required changes in the DPCPP compiler (enabled new vew/swizzle implementation in preview mode). Next step is to work on this after DPCPP compiler in this repo CI is updated.

@bader
Copy link
Contributor

bader commented May 1, 2025

KhronosGroup/SYCL-Docs#800 is now merged.

I've implemented the required changes in the DPCPP compiler (enabled new vew/swizzle implementation in preview mode). Next step is to work on this after DPCPP compiler in this repo CI is updated.

@aelovikov-intel, I can update the DPC++ compiler version in CI. Please, specify the version for the update.

@aelovikov-intel
Copy link
Contributor Author

@aelovikov-intel, I can update the DPC++ compiler version in CI. Please, specify the version for the update.

intel/llvm@8f685c4 was the last vec/swizzle commit in DPCPP. Seems that 2025-05-01 is the first build including it (if I'm reading Github's
image
correctly).

@bader
Copy link
Contributor

bader commented May 1, 2025

@aelovikov-intel, DPC++ compiler version is updated by #1087.

@aelovikov-intel aelovikov-intel requested a review from tomdeakin May 2, 2025 23:41
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@keryell
Copy link
Member

keryell commented May 21, 2025

Is it good to go? @tomdeakin

@tomdeakin
Copy link
Contributor

WG approved to merge

@bader bader merged commit 04bdffc into KhronosGroup:main May 22, 2025
9 checks passed
@aelovikov-intel aelovikov-intel deleted the vec-byte branch May 26, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Spec change] Allow "std::byte" as "vec" element type

4 participants