-
Notifications
You must be signed in to change notification settings - Fork 91
Restore relational/logical operators tests for sycl::vec
#1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems to have been removed accidentally in KhronosGroup#130.
Only meaningful after KhronosGroup#1059
keryell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something not implemented in SimSYCL?
Co-authored-by: Ronan Keryell <[email protected]>
Based on the error, it's implemented incorrectly: Result of relational/logical operations should have fixed-width integer type of the same size as operand's element type, not |
keryell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Is the SimSYCL team watching this?
bader
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, disable failing tests for SimSYCL implementation. PR must not regress CI checks.
bader
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Seems to have been removed accidentally in #130.
KhronosGroup/SYCL-Docs#675 might be considered somewhat related.