Minor changes needed for future commits #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assert is redundant because the allowed size of Components is checked by Type. Moreover it can interfere with capabilities allowing non-standart sizes.
svenvh
approved these changes
May 27, 2020
Contributor
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
One comment about the test, otherwise - LGTM
AlexeySotkin
pushed a commit
that referenced
this pull request
Jun 26, 2020
* Refined condition for CapabilityVector16 * Removed redundant assert from SPIRVVectorShuffle This assert is redundant because the allowed size of Components is checked by Type. Moreover it can interfere with capabilities allowing non-standart sizes. * Added required capabilities for ExecutionModeSubgroupSize * Added missing float control capabilities to SPIRVIsValidEnum.h Change-Id: I6f21f2375d4d905a181098dfb539fe162f9b1f95
AlexeySotkin
pushed a commit
that referenced
this pull request
Jul 8, 2020
* Refined condition for CapabilityVector16 * Removed redundant assert from SPIRVVectorShuffle This assert is redundant because the allowed size of Components is checked by Type. Moreover it can interfere with capabilities allowing non-standart sizes. * Added required capabilities for ExecutionModeSubgroupSize * Added missing float control capabilities to SPIRVIsValidEnum.h
AlexeySotkin
pushed a commit
that referenced
this pull request
Jul 17, 2020
* Refined condition for CapabilityVector16 * Removed redundant assert from SPIRVVectorShuffle This assert is redundant because the allowed size of Components is checked by Type. Moreover it can interfere with capabilities allowing non-standart sizes. * Added required capabilities for ExecutionModeSubgroupSize * Added missing float control capabilities to SPIRVIsValidEnum.h
AlexeySotkin
pushed a commit
that referenced
this pull request
Jul 17, 2020
* Refined condition for CapabilityVector16 * Removed redundant assert from SPIRVVectorShuffle This assert is redundant because the allowed size of Components is checked by Type. Moreover it can interfere with capabilities allowing non-standart sizes. * Added required capabilities for ExecutionModeSubgroupSize * Added missing float control capabilities to SPIRVIsValidEnum.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are four one-liner commits which are necessary for future changes.