Add support for the execution mode RegisterMapInterfaceINTEL#309
Closed
tiwaria1 wants to merge 0 commit intoKhronosGroup:mainfrom
Closed
Add support for the execution mode RegisterMapInterfaceINTEL#309tiwaria1 wants to merge 0 commit intoKhronosGroup:mainfrom
tiwaria1 wants to merge 0 commit intoKhronosGroup:mainfrom
Conversation
|
|
Contributor
Author
Contributor
Author
|
Also requesting a review from : @alan-baker or @johnkslang :) |
MrSidims
approved these changes
Dec 12, 2022
bashbaug
requested changes
Dec 12, 2022
| "parameters" : [ | ||
| { "kind" : "LiteralInteger", "name" : "'AcceptDownstreamStall'" } | ||
| ], | ||
| "capabilities" : [ "FPGAKernelAttributesINTELv2" ], |
Contributor
There was a problem hiding this comment.
We also need to add the new FPGAKernelAttributesINTELv2 capability to the grammar file.
Contributor
There was a problem hiding this comment.
I think the name of the capability should also be FPGAKernelAttributesv2INTEL? In other words, the INTEL suffix should remain at the end of the capability name, and v2 should be before the suffix.
Contributor
Author
There was a problem hiding this comment.
Added capability to the grammar file and renamed it here as well as in the extension doc. Had to open a new PR: #317 (because this was automatically closed by git when I tried syncing my fork)
tiwaria1
force-pushed
the
register_map_interface
branch
from
5f22348 to
aa331ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This SPIRV extension update will be introducing the new execution mode RegisterMapInterfaceINTEL. This PR adds support for this new mode.
NOTE
This execution mode is being added to an existing extension
SPV_INTEL_kernel_attributesand is guarded by a new capabilityFPGAKernelAttributesv2INTELwhich implicitly defines the existing capabilityFPGAKernelAttributesINTEL.