-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comic Rework, New Scanner, Foundation Overahul (is this a full release?) #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivamAmin
pushed a commit
to ShivamAmin/Kavita
that referenced
this pull request
Apr 6, 2024
…e?) (Kareadita#2796) Co-authored-by: majora2007 <[email protected]> Co-authored-by: Joseph Milazzo <[email protected]>
ShivamAmin
pushed a commit
to ShivamAmin/Kavita
that referenced
this pull request
Apr 6, 2024
…e?) (Kareadita#2796) Co-authored-by: majora2007 <[email protected]> Co-authored-by: Joseph Milazzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a MASSIVE PR containing over 170 dev hours and 30K lines of code. This brings support for flexible number support (chapter 0, chapter -1, chapter ∞), a new Parsing architecture, and a new library ComicVine that is for the hardcode comic collectors and aligns with best practices from Mylar/ComicVine/CBL.
As this PR is so large, expect all external apps to not work with the nighties until developers have time to adapt. This PR also requires up to 10 minutes to run mandatory migrations. You must wait this whole time. Stopping prematurely will lead to data loss or a corrupted DB.
This PR also includes a lot of manual migrations to keep reading progress, especially around loose leaf chapters and specials. I spent 20 hours working the migrations to try my best to retain as much progress as possible. Kavita will export a progress_export.csv in your config folder in case anything is missed during the migrations or you loose data after the force scan.
You MUST do Force Scans on all libraries for things to work correctly. This is mandatory!
Added
Changed
Fixed
Removed
API
External Apps
External app developers have been notified already of changes
Closes #2542