Remove the duplicate radicals #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a script to remove all of the duplicate radicals. I spot checked the geometry, and it seems that the first group is always the right one to keep, because of the stroke order, so I just removed all the other radical values on groups except the first one. I did not actually go to the trouble of sorting the geometries in order since there didn't seem to be any exceptions to the "first is upper left" rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a script to remove all of the duplicate radicals. I spot
checked the geometry, and it seems that the first group is always the
right one to keep, because of the stroke order, so I just removed all
the other radical values on groups except the first one. I did not
actually go to the trouble of sorting the geometries in order since
there didn't seem to be any exceptions to the "first is upper left"
rule.
This should fix #333