Datasets upload #149
Datasets upload #149
Conversation
| try: | ||
| api_client = KaggleApiV1Client() | ||
| api_client.post( | ||
| f"/dataset/{owner_slug}/{dataset_slug}/delete", |
There was a problem hiding this comment.
there is a typo in the path for this handler. It uses dataset instead of datasets: https://github.com/Kaggle/kaggleazure/blob/d707a9773ff13d87e12400ed5f72ba0f8286f4e7/Kaggle.Sdk/datasets/dataset_api_service.proto#L136
This is unfortunate, we can't change it without breaking older libraries. But we could add an additional binding to support both dataset/ and datasets/ path. (see example: https://github.com/Kaggle/kaggleazure/blob/d707a9773ff13d87e12400ed5f72ba0f8286f4e7/Kaggle.Sdk/datasets/dataset_api_service.proto#L72-L74)
There was a problem hiding this comment.
Can add the additional path after this goes in
| if not credentials: | ||
| self.fail("Make sure to set your Kaggle credentials before running the tests") | ||
| self.owner_slug = credentials.username | ||
| self.dataset_slug = f"dataset-{self.dataset_uuid}" |
There was a problem hiding this comment.
@jeward414 The issue was that the dataset_slug included an underscore before and underscore are not allowed in dataset slugs. They were normalized to a - instead. Which is why the creation worked, but then the next version failed because the real slug had a - instead of a _.
| with TemporaryDirectory() as temp_dir: | ||
| # Create new folder within temp_dir | ||
| inner_folder_path = Path(temp_dir) / "inner_folder" | ||
| inner_folder_path.mkdir() |
There was a problem hiding this comment.
Fixed an issue where the directory was touched (.touch()) instead of created (.mkdir()).
| if not quiet: | ||
| logger.info("Upload successful: " + file_path + " (" + File.get_size(content_length) + ")") | ||
| return token | ||
|
|
||
|
|
||
| def normalize_patterns(*, default: List[str], additional: Optional[Union[List[str], str]]) -> List[str]: |
There was a problem hiding this comment.
I moved this from models_helpers to reuse in dataset context.
| handle: (string) the dataset handle. | ||
| local_dataset_dir: (string) path to a file in a local directory. | ||
| version_notes: (string) Optional to write dataset versions. | ||
| ignore_patterns (str or List[str], optional): |
There was a problem hiding this comment.
I added support for ignore_patterns which Li added in #147
Created from @jeward414's PR (#138) and added some changes.
b/348364344