Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optional ignore_patterns parameter for model upload. #147

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

dolaameng
Copy link
Contributor

@dolaameng dolaameng commented Jul 26, 2024

Changes:

FIX=354710562
Tested (end to end)

  • Local model structure
Screenshot 2024-07-26 at 1 14 28 PM
  • Upload command: kagglehub.model_upload("limakaggle/testignore/pytorch/2", "/tmp/ignoremodel", ignore_patterns=["original/", ".gitattribute"])

  • Uploaded model

Screenshot 2024-07-26 at 1 15 58 PM

@dolaameng dolaameng requested review from rosbo, stevemessick and a team July 26, 2024 20:26
Copy link

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like GitHub is using black for formatting. You might not want to change settings in VS Code.

Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor and for the great test cases.

@rosbo
Copy link
Contributor

rosbo commented Jul 26, 2024

To help you debug the type error in python 3.7 and 3.9, you can pass the -v flag to ./docker-hatch to run using a specific Python version: https://github.com/Kaggle/kagglehub?tab=readme-ov-file#running-hatch-commands-inside-docker

@dolaameng dolaameng requested a review from stevemessick July 26, 2024 21:32
@dolaameng dolaameng changed the title [RFC] Implement optional ignore_patterns parameter for model upload. Implement optional ignore_patterns parameter for model upload. Jul 29, 2024
@dolaameng dolaameng merged commit 7de4cc2 into main Jul 29, 2024
7 checks passed
@dolaameng dolaameng deleted the limagoog/feat/model_uploda_ignore_patterns branch July 29, 2024 17:17
@rosbo rosbo mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants