Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lofty-rs for metadata instead of audiotags #21

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Use lofty-rs for metadata instead of audiotags #21

merged 3 commits into from
Jun 30, 2023

Conversation

FriederHannenheim
Copy link
Contributor

Replaces #17. Fixes #15

@FriederHannenheim FriederHannenheim mentioned this pull request Jun 26, 2023
Closed
@FriederHannenheim
Copy link
Contributor Author

For now this uses my own lofty-rs fork, which is a bit more relaxed when parsing tags. Upstream lofty will just error if the tag is invalid. My patch allows it to return the valid tags.
A feature for lofty is planned to implement a Relaxed ReadingMode which would do the same thing. Then upstream lofty can be used. Serial-ATA/lofty-rs#204 (comment)

@KRTirtho
Copy link
Owner

LGTM and works fine too

@KRTirtho KRTirtho merged commit 0bc54f6 into KRTirtho:main Jun 30, 2023
@KRTirtho
Copy link
Owner

KRTirtho commented Jul 1, 2023

metadata_god v0.5.0 is published to pub.dev
@FriederHannenheim Thanks a lot for this amazing contribution. You basically re-wrote entire lib 😄 🚀

@Feichtmeier
Copy link

@FriederHannenheim are bits missing to make metadata god read out ogg files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use lofty-rs for reading metadata instead of audiotags
3 participants
@FriederHannenheim @KRTirtho @Feichtmeier