Use lofty-rs for metadata instead of audiotags #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait. Don't merge this yet. Lofty does support album artist. I just didn't see it since there is no direct method for it. |
|
Alright. Album Artist is now working correctly |
|
Wow that's a wonderful and huge work ❤️ 🚀 |
This reverts commit 2577940.
…by default for some godforsaken reason
|
@FriederHannenheim sorry for the delay. I've checked it and your implementation works quite well |
|
But what will do about the Since you're actively using the fork's |
|
Alright new, cleaner pull request is #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a quick and dirty implementation. The api could be changed so that not so many type conversions would be needed. I'm not really sure how the bindings work though so I didn't change it now.
This fixes #15 and enables reading many more types of tags.
Downside: album_artist isn't supported by lofty and is just mapped to artist