CMake: Add custom CMake code to simplify build #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
force-pushed
the
963-custom-cmake
branch
3 times, most recently
from
1c1c062 to
5bf7d30
Compare
This allows us to get away without whole-archive in CMake by declaring an OBJECT library instead.
Otherwise, Ninja will complain, as it needs **some** rule to build the target, even if that rule does nothing.
This caused a build failure when not building a binary. Linking the object file in shouldn't produce issues.
LeonMatthesKDAB
force-pushed
the
963-custom-cmake
branch
2 times, most recently
from
2236f5c to
adbd9a2
Compare
And don't redirect the first build output to /dev/null This should allow us to see what exactly is failing in CI.
LeonMatthesKDAB
force-pushed
the
963-custom-cmake
branch
from
adbd9a2 to
9aa28be
Compare
Otherwise the linker order doesn't work out and the linker cannot resolve the qt_static_plugin_*** functions
It's much more concise than using File::create followed by write!
LeonMatthesKDAB
force-pushed
the
963-custom-cmake
branch
from
bf921d5 to
52bdd53
Compare
This can be used to e.g. register custom types, import plugins, declare modules, etc.
LeonMatthesKDAB
force-pushed
the
963-custom-cmake
branch
from
52bdd53 to
5451dae
Compare
This reverts commit 40f5ad1. We are now building and linking object files directly, which works nicely with CMake and seems to work for Rust as well.
This may be a clippy bug, as `cargo expand` tells me the generated functions do indeed have a `# Safety` section in their documentation. The `# Safety` sections also show up in the output of `cargo doc`. So it's unclear why clippy is complaining.
LeonMatthesKDAB
force-pushed
the
963-custom-cmake
branch
from
3c2811f to
1757f09
Compare
This way we don't need a separate object file and CMake target for this.
This was referenced Jun 21, 2024
Thanks to @ahayzen-kdab for the review.
This way we don't run into issues where multiple build scripts are writing to the same initializers file.
ahayzen-kdab
approved these changes
Jun 21, 2024
Collaborator
ahayzen-kdab
left a comment
ahayzen-kdab
left a comment
There was a problem hiding this comment.
Lets go with this for now and hope that the manifest folders work as described in #983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.