Only use whole-archive on the -initalizers library that contains QML plugins/resources
#963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2024 11:53
Previously, we linked the entire staticlib generated by the Rust compiler into our CMake target. This was part of what caused the recent issues in CI (see KDAB#958). Cargo already only linked the plugin&resources library as whole-archive, which is where where it is needed. Now we simply export the initializers library into the CXXQT_EXPORT_DIR, so we can only link the initializers with whole-archive. This is a lot cleaner and should lead to fewer linker failures. Closes KDAB#958
Collaborator
Author
|
Okay, new problem, now the cxx-qt-lib initializers aren't being included, as they're just part of the main binary linked by cargo, not the -initializers library... |
Collaborator
|
Separately i'll explore having an init() method |
Collaborator
Working build is here #964 |
Collaborator
Author
|
Closing in favor of #978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #958