-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI: No nightly tests, improve macOS CI setup + use julia-actions/cache #1863
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1863 +/- ##
=======================================
Coverage 85.96% 85.96%
=======================================
Files 144 144
Lines 8647 8647
=======================================
Hits 7433 7433
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
I don't think that will happen. There will only be a single run for |
Indeed, my comment above was incorrect: I was already assuming that we would want to change that PR such that we continue testing with the latest stable release. |
I'm wondering if it's worthwhile to add all the complexity to the CI.yml file for this, though. I think testing prereleases in dedicated PRs is reasonable. It requires a little effort but not much. |
I agree, in particular given that tests seem to fail on the prerelease as well (and the fact that the PR in its current state actually doesn't skip the duplicate runs). |
* Increase sample size when testing empirical moments of DiscreteNonParametric * Use StableRNGs for semicircle.jl to avoid breakage on 1.11-beta * Run CI on all PRs. Also CI for workflow_dispatch and merge_group * Update semicircle.jl Co-authored-by: David Widmann <[email protected]> * Update locationscale.jl Co-authored-by: David Widmann <[email protected]> * Update locationscale.jl Co-authored-by: David Widmann <[email protected]> --------- Co-authored-by: David Widmann <[email protected]>
In this draft I see if one can achieve something like #1861 without running tests twice if no prerelease is available. Additionally,This PR removes the nightly tests (see #1861), includes a fix for the mac CI setup (see #1856), and switches to julia-actions/cache for caching.Edit: The PR also includes #1862 which fixes tests on Julia 1.11-beta1 (see #1862 (comment)).