Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI: No nightly tests, improve macOS CI setup + use julia-actions/cache #1863

Merged
merged 10 commits into from
Jun 28, 2024

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented May 27, 2024

In this draft I see if one can achieve something like #1861 without running tests twice if no prerelease is available. Additionally, This PR removes the nightly tests (see #1861), includes a fix for the mac CI setup (see #1856), and switches to julia-actions/cache for caching.

Edit: The PR also includes #1862 which fixes tests on Julia 1.11-beta1 (see #1862 (comment)).

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.96%. Comparing base (f852803) to head (8aee234).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1863   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files         144      144           
  Lines        8647     8647           
=======================================
  Hits         7433     7433           
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack
Copy link
Member

without running tests twice if no prerelease is available.

I don't think that will happen. There will only be a single run for julia@1 but that run might be a prerelease, see https://github.com/JuliaStats/Distributions.jl/actions/runs/9250768369/job/25444947763?pr=1862, and maybe that is not what we want.

@devmotion
Copy link
Member Author

There will only be a single run for julia@1 but that run might be a prerelease,

Indeed, my comment above was incorrect: I was already assuming that we would want to change that PR such that we continue testing with the latest stable release.

@andreasnoack
Copy link
Member

I'm wondering if it's worthwhile to add all the complexity to the CI.yml file for this, though. I think testing prereleases in dedicated PRs is reasonable. It requires a little effort but not much.

@devmotion
Copy link
Member Author

I agree, in particular given that tests seem to fail on the prerelease as well (and the fact that the PR in its current state actually doesn't skip the duplicate runs).

@devmotion devmotion marked this pull request as ready for review May 27, 2024 14:52
@devmotion devmotion changed the title Test prereleases if available Update CI: No nightly tests, improve macOS CI setup + use julia-actions/cache May 27, 2024
* Increase sample size when testing empirical moments of DiscreteNonParametric

* Use StableRNGs for semicircle.jl to avoid breakage on 1.11-beta

* Run CI on all PRs. Also CI for workflow_dispatch and merge_group

* Update semicircle.jl

Co-authored-by: David Widmann <[email protected]>

* Update locationscale.jl

Co-authored-by: David Widmann <[email protected]>

* Update locationscale.jl

Co-authored-by: David Widmann <[email protected]>

---------

Co-authored-by: David Widmann <[email protected]>
@devmotion devmotion merged commit 65f056c into master Jun 28, 2024
12 checks passed
@devmotion devmotion deleted the dw/ci_prerelease branch June 28, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants