Fix failing tests on 1.11-beta #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## andreasnoack-patch-1 #1862 +/- ##
========================================================
- Coverage 85.96% 85.87% -0.09%
========================================================
Files 144 144
Lines 8647 8636 -11
========================================================
- Hits 7433 7416 -17
- Misses 1214 1220 +6 ☔ View full report in Codecov by Sentry. |
devmotion
reviewed
May 27, 2024
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
devmotion
approved these changes
May 27, 2024
|
This one was against my other PR. I think we should cherry-pick what's here and go with your PR instead. |
devmotion
added a commit
that referenced
this pull request
May 27, 2024
* Increase sample size when testing empirical moments of DiscreteNonParametric * Use StableRNGs for semicircle.jl to avoid breakage on 1.11-beta * Run CI on all PRs. Also CI for workflow_dispatch and merge_group * Update semicircle.jl Co-authored-by: David Widmann <[email protected]> * Update locationscale.jl Co-authored-by: David Widmann <[email protected]> * Update locationscale.jl Co-authored-by: David Widmann <[email protected]> --------- Co-authored-by: David Widmann <[email protected]>
devmotion
added a commit
that referenced
this pull request
Jun 28, 2024
…ns/cache (#1863) * Test prereleases if available * Fix name? * Fix matrix * Fixes * Fix syntax * Another round of fixes * Remove prerelease CI * Better mac fix? * Fix typo * Fix failing tests on 1.11-beta (#1862) * Increase sample size when testing empirical moments of DiscreteNonParametric * Use StableRNGs for semicircle.jl to avoid breakage on 1.11-beta * Run CI on all PRs. Also CI for workflow_dispatch and merge_group * Update semicircle.jl Co-authored-by: David Widmann <[email protected]> * Update locationscale.jl Co-authored-by: David Widmann <[email protected]> * Update locationscale.jl Co-authored-by: David Widmann <[email protected]> --------- Co-authored-by: David Widmann <[email protected]> --------- Co-authored-by: Andreas Noack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a slightly larger sample size when testing DiscreteNonParametric to ensure that empirical moments are close enough to theoretical moments.
The semicircle tests were also vulnerable to changes to the drawn variates so I've switched from MersenneTwister to StableRNGs.