NStepBatchSampler #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 73.54% 74.44% +0.89%
==========================================
Files 15 15
Lines 756 763 +7
==========================================
+ Hits 556 568 +12
+ Misses 200 195 -5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
jeremiahpslewis
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks NStepBatchSampler. It now exploits the episode information of EpisodesBuffer.
This was an attempt to solve the issue discussed in JuliaReinforcementLearning/ReinforcementLearning.jl#966.
It turns out that the issue was not caused by NStepBatchSampler but by the prioritized exp replay. Apparently setting a priority to 0 does not guarantee that the index will never be sampled. So it occasionally happens with low probability. I'll propose a fix to this in another PR to keep things separate.