TargetNetwork #966
Merged
TargetNetwork #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremiahpslewis I tried to replicate the error of the experiments in a8acb2d. This seems to be an error that happens with very low probability. It looks like an action "0" is occasionally sampled an leads to an out of bounds error. This 0 I think is a dummy action used in RLTrajectories padding... So there's a sneaky bug to find. Edit: this is because the prioritized replay experiment uses NStepBatchSampler, which is not adapted to the EpisodesBuffer yet. |
There was a problem hiding this comment.
@HenriDeh I can review things again once I've submitted my master's thesis end of next week. Looking forward to digging into this!
jeremiahpslewis
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started when I wanted to clean up a bit the RLCore structure. Then I noticed that TargetNetworks are currently named TwinNetworks (incorrect naming see #961). I went down the rabbit hole of refactoring it in addition to simply renaming it. I created a doc page, I invite you to read it to understand the point of this PR.
I've refactored all DQNs algorithms, they are now agnostic to the use of a target or not. MPO also uses the new struct (here it is enforced by type restrictions).
I have yet to create some test for the new struct but I'd like your opinion on what I converged to.
PR Checklist