-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps #34
Bump deps #34
Conversation
@mateuszbaran, any idea why the tests fails now, and how we can fix this ? cc @johnnychen94 who might know Macros: Error During Test at /home/runner/work/VisualRegressionTests.jl/VisualRegressionTests.jl/src/macros.jl:18
Test threw exception
Expression: test_images(testFilename, "PlotTest.png", popup = !istravis, tol = 0.02) |> success
MethodError: no method matching +(::Float64, ::RGB{Float64})
Math on colors is deliberately undefined in ColorTypes, but see the ColorVectorSpace package.
Closest candidates are:
+(::Any, ::Any, !Matched::Any, !Matched::Any...) at operators.jl:560
+(::Union{Float16, Float32, Float64}, !Matched::BigFloat) at mpfr.jl:392
+(!Matched::AbstractRGB, ::AbstractRGB) at /home/runner/.julia/packages/ColorVectorSpace/s7hKD/src/ColorVectorSpace.jl:262
...
Stacktrace:
[1] sumdiff
@ ~/work/VisualRegressionTests.jl/VisualRegressionTests.jl/src/utils.jl:34 [inlined]
[2] sad
@ ~/work/VisualRegressionTests.jl/VisualRegressionTests.jl/src/utils.jl:26 [inlined]
[3] blurdiff(A::Matrix{RGB{FixedPointNumbers.N0f8}}, B::Matrix{RGB{FixedPointNumbers.N0f8}}, sigma::Tuple{Int64, Int64})
@ VisualRegressionTests ~/work/VisualRegressionTests.jl/VisualRegressionTests.jl/src/utils.jl:19
[4] compare_images(testfn::String, reffn::String; sigma::Tuple{Int64, Int64}, tol::Float64)
@ VisualRegressionTests ~/work/VisualRegressionTests.jl/VisualRegressionTests.jl/src/imgcomp.jl:15
[5] test_images(testfn::String, reffn::String; popup::Bool, newfn::String, kw::Base.Iterators.Pairs{Symbol, Float64, Tuple{Symbol}, NamedTuple{(:tol,), Tuple{Float64}}})
@ VisualRegressionTests ~/work/VisualRegressionTests.jl/VisualRegressionTests.jl/src/imgcomp.jl:31
[6] macro expansion
@ ~/work/VisualRegressionTests.jl/VisualRegressionTests.jl/src/macros.jl:18 [inlined]
[7] macro expansion
@ ~/work/VisualRegressionTests.jl/VisualRegressionTests.jl/test/runtests.jl:29 [inlined]
[8] macro expansion
@ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
[9] macro expansion
@ ~/work/VisualRegressionTests.jl/VisualRegressionTests.jl/test/runtests.jl:27 [inlined]
[10] macro expansion
@ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
[11] top-level scope
@ ~/work/VisualRegressionTests.jl/VisualRegressionTests.jl/test/runtests.jl:18 |
I would guess that you should replace VisualRegressionTests.jl/src/utils.jl Line 26 in cb64334
|
There are some hard landings here for the recent CVS development, one of the major breaking change is that To upgrade the codebase to [email protected], one needs to define his own |
Thanks for taking the time to answer, very clear. |
29d377a
to
794567f
Compare
Images dependency might be too large for this package; and Images isn't yet compatible with CVS 0.9 yet so you might get a fake fix by adding Images dependency. |
The reason why I'm trying to add Is there a reason why these algorithms are not in It's cumbersome: |
794567f
to
1c6b1b4
Compare
Ah okay, that now lives in ImageBase v0.1.3 ImageCore is designed to be a collection of traits and array types so we don't add many functions there. |
See also JuliaImages/ImageBase.jl#14 |
Oh thanks for pointing |
0f1e84f
to
da80d91
Compare
da80d91
to
48392ca
Compare
God, that took an awful number of runs to get fixed for an equivalent |
No description provided.