You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oh that's interesting. I noticed the tests looked a little thin, but I had no idea that I'd changed the implementation.
Do you think we should keep the original scalar-return, or is channelwise better? We have the chance to make a breaking change, of course, and I don't think it's heavily used.
Without considering the compatibility with Images.jl, which I've fixed in JuliaImages/Images.jl@bad872f, I prefer channelwise output as it gives more information on the pixel instead of just the abs value.
I also notice that
kwargs
are not tested.Looks like we need more comprehensive tests and compatibility tests for these functions.
The text was updated successfully, but these errors were encountered: