SDL2: Add -no-undefined to LD_FLAGS for libSDL2main
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and libSDL2_test.la)
giordano
reviewed
Dec 28, 2019
NHDaly
changed the title
-no-undefined to LD_FLAGS for libSDL2main-no-undefined to LD_FLAGS for libSDL2main
NHDaly
changed the title
-no-undefined to LD_FLAGS for libSDL2main-no-undefined to LD_FLAGS for libSDL2main
NHDaly
changed the title
-no-undefined to LD_FLAGS for libSDL2main-no-undefined to LD_FLAGS for libSDL2main
Oops, wrap new flags in parens, per @giordano's suggestion Co-Authored-By: Mosè Giordano <[email protected]>
|
Huh, it's weird that half those builds failed, when i didn't change anything. Were those ever succeeding? It's hard to tell, because it looks like CI wasn't set up when this package was first added?: Also, it looks like the flag either wasn't picked up or wasn't effective, because the warning remains: |
|
We don't need this anymore, but we should figure out why those platforms are now failing.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-no-undefinedto LD_FLAGS forlibSDL2main(andlibSDL2_test.la)Attempting to fix problems in #123