Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder for SDL2 #27

Merged
merged 1 commit into from
Sep 29, 2019
Merged

Add builder for SDL2 #27

merged 1 commit into from
Sep 29, 2019

Conversation

giordano
Copy link
Member

@giordano giordano commented Aug 3, 2019

This is the builder for SDL2. Originally at https://github.com/giordano/SDL2Builder.

Note: this is not working. My understanding is that it compiles for the wrong target system. E.g., the compiler used for macOS is /opt/x86_64-linux-gnu/tools/clang --sysroot=/opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root instead of /opt/x86_64-linux-gnu/tools/clang -target x86_64-apple-darwin14 --sysroot /opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root (note the missing -target option). Everything works now.

CC: @aviks.

@giordano
Copy link
Member Author

giordano commented Aug 3, 2019

Ok, apparently the build for Windows works, too. The missing systems are macOS and FreeBSD. What I see on these platform is that the preprocessor enters branches like

#ifdef __linux__

I thought it was a problem of clang, but using GCC toolchain doesn't let me compile the library anyway.

@giordano
Copy link
Member Author

giordano commented Aug 8, 2019

Sdl2 provides runtime binaries: https://www.libsdl.org/download-2.0.php We could extract the libraries from there for some platforms. The only thing that I didn't know was how to extract a dmg, but it turned out 7zip can open it. @aviks what are your thoughts?

@aviks
Copy link
Contributor

aviks commented Aug 8, 2019 via email

@giordano
Copy link
Member Author

I think an old version of this pull request slipped into 029e588 🤔

@staticfloat
Copy link
Member

uhhhhhh WHOOPS. Heh, yeah, I must have accidentally done a git commit -av.

@giordano
Copy link
Member Author

Apparently simply switching to autotools made all issues go away. I've just built the package for all platforms. My trust in CMake was misplaced.

@staticfloat
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants