Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate over readmeta results #1308

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Iterate over readmeta results #1308

merged 4 commits into from
Jan 14, 2024

Conversation

eschnett
Copy link
Contributor

No description provided.

@eschnett
Copy link
Contributor Author

I couldn't run the test suite because

[13:48:09] ../meson.build:1:0: ERROR: Unable to detect linker for compiler `/opt/bin/x86_64-apple-darwin14-libgfortran4-cxx11-julia_version+1.7.3/x86_64-apple-darwin14-clang++ -Wl,--version -L/workspace/destdir/lib -fuse-ld=/opt/bin/x86_64-apple-darwin14-libgfortran4-cxx11-julia_version+1.7.3/x86_64-apple-darwin14-ld`
[13:48:09] stdout:
[13:48:09] stderr: ld: warning: directory not found for option '-L/workspace/destdir/lib'
[13:48:09] ld: unknown option: --version
[13:48:09] clang-16: error: linker command failed with exit code 1 (use -v to see invocation)

That is, it fails because the Apple linkers aren't set up correctly. I think it's the same problem as JuliaPackaging/Yggdrasil#7745.

@eschnett
Copy link
Contributor Author

The meson build failure happens for me locally but not in CI.

@giordano
Copy link
Member

We probably need to update BinaryBuilderBase first: https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/6faea2ef758b089156f35716d0f55dc74a8ab786/test/Project.toml#L16

@eschnett
Copy link
Contributor Author

eschnett commented Jan 1, 2024

This PR depends on JuliaPackaging/BinaryBuilderBase.jl#363.

@eschnett eschnett marked this pull request as draft January 1, 2024 19:02
@eschnett
Copy link
Contributor Author

eschnett commented Jan 4, 2024

This PR probably needs to disable ObjectFile 0.3. Should I do this, or should I add a function with a @static if condition to handle both versions?

@giordano
Copy link
Member

giordano commented Jan 4, 2024

Only v0.4 is fine

@eschnett
Copy link
Contributor Author

eschnett commented Jan 4, 2024

It seems Manifest.toml is committed into the repository. Should I updated it as well? Or should I remove it?

@giordano
Copy link
Member

I'm not a fan of committing the Manifest in packages, but let's update it for the time being.

@eschnett eschnett marked this pull request as ready for review January 11, 2024 19:03
@giordano giordano merged commit e7adb8b into JuliaPackaging:compathelper/new_version/2023-04-11-19-28-50-862-00605624957 Jan 14, 2024
2 checks passed
giordano pushed a commit that referenced this pull request Jan 14, 2024
@eschnett @giordano
Iterate over readmeta results (#1308)
8d917f9 
* Iterate over `readmeta` results

* Correct get_soname

* Require ObjectFile 0.4

* Update Manifest.toml
giordano added a commit that referenced this pull request Jan 14, 2024
@github-actions @eschnett @giordano
CompatHelper: bump compat for ObjectFile to 0.4, (keep existing compa…
546aa95 
…t) (#1277)

* CompatHelper: bump compat for ObjectFile to 0.4, (keep existing compat)

* Iterate over `readmeta` results (#1308)

* Iterate over `readmeta` results

* Correct get_soname

* Require ObjectFile 0.4

* Update Manifest.toml

* Fix test

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Erik Schnetter <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eschnett @giordano