Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for ObjectFile to 0.4, (keep existing compat) #1277

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ObjectFile package from 0.3.6 to 0.3.6, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@giordano giordano force-pushed the compathelper/new_version/2023-04-11-19-28-50-862-00605624957 branch from a1cbd5b to e8df754 Compare December 14, 2023 00:49
@eschnett
Copy link
Contributor

The function readmeta in ObjectFile now returns a one-element vector instead of a scalar. (Except for fat MachO binaries, these are still returned as scalars and they are iterable.)

I think the solution is to loop over the return values of readmeta. Or we can use only as stop-gap measure.

@eschnett
Copy link
Contributor

@giordano What do you think about adding loops as I suggest above?

@giordano
Copy link
Member

I think that sounds good, and readmeta returning a vector instead instead of a single object matches my recollection of the problem.

CompatHelper Julia and others added 2 commits January 14, 2024 19:07
* Iterate over `readmeta` results

* Correct get_soname

* Require ObjectFile 0.4

* Update Manifest.toml
@giordano giordano force-pushed the compathelper/new_version/2023-04-11-19-28-50-862-00605624957 branch from e7adb8b to 8d917f9 Compare January 14, 2024 19:11
@giordano giordano merged commit 546aa95 into master Jan 14, 2024
7 of 9 checks passed
@giordano giordano deleted the compathelper/new_version/2023-04-11-19-28-50-862-00605624957 branch January 14, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants