Skip to content

deps: re-sign bundled zstd on macOS #61355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fingolfin merged 1 commit into from
Mar 20, 2026
Merged

deps: re-sign bundled zstd on macOS #61355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions deps/zstd.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,13 @@ post-install-zstd: $(build_prefix)/manifest/zstd $(PATCHELF_MANIFEST)
[ -e $(build_private_libexecdir)/zstd$(EXE) ]
[ -e $(build_private_libexecdir)/zstdmt$(EXE) ]
ifeq ($(OS), Darwin)
# zstd is relocated from bin/ to libexec/julia/, so its JLL rpath must be updated to keep finding ../libzstd.
# but this invalidates the existing signature, and macOS can then refuse to launch zstd, so also call codesign.
for j in zstd zstdmt ; do \
[ -L $(build_private_libexecdir)/$$j ] && continue; \
install_name_tool -rpath @executable_path/$(reverse_build_private_libexecdir_rel) @loader_path/$(build_libdir_rel) $(build_private_libexecdir)/$$j 2>/dev/null || true; \
install_name_tool -rpath @loader_path/$(build_libdir_rel) @executable_path/$(reverse_build_private_libexecdir_rel) $(build_private_libexecdir)/$$j || exit 1; \
codesign -s - -f $(build_private_libexecdir)/$$j || exit 1; \
done
else ifneq (,$(findstring $(OS),Linux FreeBSD))
for j in zstd zstdmt ; do \
Expand Down
3 changes: 3 additions & 0 deletions stdlib/Zstd_jll/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,7 @@ using Test, Zstd_jll

@testset "Zstd_jll" begin
@test ccall((:ZSTD_versionNumber, libzstd), Cuint, ()) == 1_05_07
let version = read(`$(zstd()) --version`, String)
@test contains(version, "Zstandard CLI")
end
end
Loading