deps: re-sign bundled zstd on macOS#61355
Merged
Conversation
Rewriting the bundled zstd executables with install_name_tool invalidates their existing signatures on macOS. Re-sign them ad hoc after updating the rpath so the CLI remains launchable for Pkg archive decompression. Add a regression test that runs the bundled zstd executable instead of only checking that libzstd can be loaded. Fixes #61354 Co-authored-by: Codex <codex@openai.com>
fingolfin
force-pushed
the
codex/zstd-codesign-fix
branch
from
caadd12 to
82f984b
Compare
Member
Author
giordano
approved these changes
Mar 20, 2026
Member
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
Couldn't test it as I don't have macOS 26, but looks reasonable, and as mentioned in #61354 (comment) we do already something similar in https://github.com/JuliaLang/julia/blob/da0d31d142f531cac1f4e388ba5b16792da49b9f/contrib/mac/app/Makefile for the distributed tarballs.
KristofferC
pushed a commit
that referenced
this pull request
Mar 24, 2026
Rewriting the bundled zstd executables with install_name_tool invalidates their existing signatures on macOS. Re-sign them ad hoc after updating the rpath so the CLI remains launchable for Pkg archive decompression. Add a regression test that runs the bundled zstd executable instead of only checking that libzstd can be loaded. Fixes #61354 (but see discussion there as to whether it really does?) Co-authored-by: Codex <codex@openai.com> Co-authored-by: Codex <codex@openai.com> (cherry picked from commit 3de619d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewriting the bundled zstd executables with install_name_tool
invalidates their existing signatures on macOS. Re-sign them ad
hoc after updating the rpath so the CLI remains launchable for Pkg
archive decompression.
Add a regression test that runs the bundled zstd executable
instead of only checking that libzstd can be loaded.
Fixes #61354 (but see discussion there as to whether it really does?)
Co-authored-by: Codex codex@openai.com