[1.12] Don't skip CIs from external absints #60741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Jan 19, 2026
Co-authored-by: Valentin Churavy <[email protected]>
Co-authored-by: Dilum Aluthge <[email protected]>
DilumAluthge
force-pushed
the
gb/cache-skip
branch
from
53692c7 to
b567b6c
Compare
Member
|
Does this need to be forwardported? |
Member
Yes, see #60747 |
DilumAluthge
removed
the
merge me
vtjnash
reviewed
Feb 5, 2026
| function check_presence(mi, token) | ||
| ci = isdefined(mi, :cache) ? mi.cache : nothing | ||
| while ci !== nothing | ||
| if ci.owner === token && ci.max_world == typemax(UInt) |
Member
There was a problem hiding this comment.
Something probably went horribly wrong if ci.max_world != WORLD_AGE_REVALIDATION_SENTINEL, since that means the Compiler made a mistake and forgot to validate it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix one of the GPUCompiler caching issues