Fix JET warnings in show(::IOBuffer, ::StackFrame)
#60645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Jan 14, 2026
fingolfin
added
backport 1.12
Member
|
This PR has the @lgoettgens or @fingolfin - would you be able to put together a manual backport to 1.12? |
Contributor
Author
I'll do it (and then ping you there) |
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 19, 2026
…60740) This backports the part of #60645 that is applicable to 1.12. Furthermore, I added a type assertion two lines above the other changes that was taken from #58430. Without this, there are still JET warnings in 1.12 for the above query. cc @DilumAluthge
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 19, 2026
…60740) This backports the part of #60645 that is applicable to 1.12. Furthermore, I added a type assertion two lines above the other changes that was taken from #58430. Without this, there are still JET warnings in 1.12 for the above query. cc @DilumAluthge
KristofferC
pushed a commit
that referenced
this pull request
Jan 26, 2026
This gets rid of the following JET warnings (present on julia 1.13.0-beta1 with JET aviatesk/JET.jl@377fa53 (see aviatesk/JET.jl#796 why I did not use a released version), no longer present with this patch applied onto julia 1.13.0-beta1) ```julia julia> @report_call Base.process_backtrace(Base.stacktrace(Base.backtrace())) [ Info: tracking Base ┌ Warning: skipping var"#sprint#423"(context, sizehint::Integer, ::typeof(sprint), f::Function, args...) @ Base strings/io.jl:102 to avoid parsing too much code └ @ Revise ~/.julia/packages/Revise/icvyF/src/packagedef.jl:1344 ═════ 3 possible errors found ═════ ┌ process_backtrace(t::Vector{Base.StackTraces.StackFrame}) @ Base ./errorshow.jl:1094 │┌ process_backtrace(tracecount::Vector{Any}) @ Base ./errorshow.jl:1100 ││┌ _backtrace_collapse_repeated_locations!(trace::Vector{Any}) @ Base ./errorshow.jl:1048 │││┌ sprint(f::typeof(show), args::Base.StackTraces.StackFrame) @ Base ./strings/io.jl:102 ││││┌ sprint(f::typeof(show), args::Base.StackTraces.StackFrame; context::Nothing, sizehint::Int64) @ Base ./strings/io.jl:109 │││││┌ show(io::IOBuffer, frame::Base.StackTraces.StackFrame) @ Base.StackTraces ./stacktraces.jl:331 ││││││┌ show_spec_linfo(io::IOBuffer, frame::Base.StackTraces.StackFrame) @ Base.StackTraces ./stacktraces.jl:282 │││││││┌ show_custom_spec_sig(io::IOBuffer, owner::Any, linfo::Core.CodeInstance, frame::Base.StackTraces.StackFrame) @ Base.StackTraces ./stacktraces.jl:298 ││││││││ no matching method found `show_spec_sig(::IOBuffer, ::Module, ::Any)` (1/2 union split): Base.StackTraces.show_spec_sig(io::IOBuffer, mi.def::Union{Method, Module}, mi.specTypes::Any) │││││││└──────────────────── ││││││┌ show_spec_linfo(io::IOBuffer, frame::Base.StackTraces.StackFrame) @ Base.StackTraces ./stacktraces.jl:286 │││││││┌ getproperty(x::Nothing, f::Symbol) @ Base ./Base_compiler.jl:57 ││││││││ invalid builtin function call: getfield(x::Nothing, f::Symbol) │││││││└──────────────────── ││││││┌ show_spec_linfo(io::IOBuffer, frame::Base.StackTraces.StackFrame) @ Base.StackTraces ./stacktraces.jl:286 │││││││ no matching method found `show_spec_sig(::IOBuffer, ::Nothing, ::Any)` (1/2 union split): Base.StackTraces.show_spec_sig(io::IOBuffer, def::Union{Nothing, Method}, (Base.StackTraces.frame_mi(frame::Base.StackTraces.StackFrame)::Union{Nothing, Core.MethodInstance}).specTypes::Any) ││││││└──────────────────── ``` It would be great to get this backported to 1.12 and 1.13. cc @fingolfin (cherry picked from commit 57d5fb1)
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the following JET warnings (present on julia 1.13.0-beta1 with JET aviatesk/JET.jl@377fa53 (see aviatesk/JET.jl#796 why I did not use a released version), no longer present with this patch applied onto julia 1.13.0-beta1)
It would be great to get this backported to 1.12 and 1.13.
cc @fingolfin