stacktraces: Add an extension point for printing custom-owner CIs#58430
Merged
stacktraces: Add an extension point for printing custom-owner CIs#58430
Conversation
…tances On Julia master, it is possible to add custom CodeInstances with non `nothing` owner to the runtime system (e.g. by invoking them or with custom AbstractInterpreters). However, the backtrace printing for these custom code instances was not in any way distinguished from the backtrace printing for an ordinary code instance of the same method instance, making it sometimes hard to determine what code instance a particular backtrace was referring to (if the downstream compiler was making many different code instances for a particular MethodInstance). Remidy this by adding an explicit extension point that can be overwritten to modify the printing of these custom-owner CodeInstances.
vchuravy
approved these changes
May 16, 2025
Member
vchuravy
left a comment
vchuravy
left a comment
There was a problem hiding this comment.
The only question I have is if we should print something different by default?
Member
Author
|
I don't think I want to force people to implement this interface if they don't want to, so I think keeping the default unmodified is fine for now. We can revisit. |
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 19, 2026
…60740) This backports the part of #60645 that is applicable to 1.12. Furthermore, I added a type assertion two lines above the other changes that was taken from #58430. Without this, there are still JET warnings in 1.12 for the above query. cc @DilumAluthge
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 19, 2026
…60740) This backports the part of #60645 that is applicable to 1.12. Furthermore, I added a type assertion two lines above the other changes that was taken from #58430. Without this, there are still JET warnings in 1.12 for the above query. cc @DilumAluthge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Julia master, it is possible to add custom CodeInstances with non
nothingowner to the runtime system (e.g. by invoking them or with custom AbstractInterpreters). However, the backtrace printing for these custom code instances was not in any way distinguished from the backtrace printing for an ordinary code instance of the same method instance, making it sometimes hard to determine what code instance a particular backtrace was referring to (if the downstream compiler was making many different code instances for a particular MethodInstance). Remidy this by adding an explicit extension point that can be overwritten to modify the printing of these custom-owner CodeInstances.