compare ranges by firstindex before by values (like vectors)

[adienes]

particularly important after #59500 so that ranges match vectors!

[adienes]

the old behavior is explicitly tested for, but I think those tests are incorrect, right?

[jishnub]

This seems to have some overlap with #30950, although it's much smaller in scope. I fear this will be complicated and might be breaking. The axis of an axis is often ignored -- incorrectly -- but that behavior is ancient.

[adienes]

note the following consequence:

julia> using OffsetArrays

julia> a1 = OffsetArray(Int[], 4);

julia> a2 = OffsetArray(Int[], 5);

julia> a1 == a2, axes(a1) == axes(a2)
(true, true)

julia> cmp(a1, a2), cmp(axes(a1), axes(a2))
(-1, -1)

ancient or not, shouldn't we fix it?

[jishnub]

Please go ahead by all means, I'm not vetoing this. I'll just be interested in a PkgEval run to see if this impacts the ecosystem.

[adienes]

@nanosoldier runtests()

[nanosoldier]

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

❗ Packages that crashed

1 packages crashed only on the current version.

• An internal error was encountered: 1 packages

242 packages crashed on the previous version too.

✖ Packages that failed

121 packages failed only on the current version.

• Package fails to precompile: 91 packages
• Illegal method overwrites during precompilation: 3 packages
• Package has test failures: 17 packages
• Package tests unexpectedly errored: 5 packages
• Tests became inactive: 2 packages
• Test duration exceeded the time limit: 3 packages

1994 packages failed on the previous version too.

✔ Packages that passed tests

6 packages passed tests only on the current version.

• Other: 6 packages

4026 packages passed tests on the previous version too.

~ Packages that at least loaded

5 packages successfully loaded only on the current version.

• Other: 5 packages

4010 packages successfully loaded on the previous version too.

➖ Packages that were skipped altogether

4 packages were skipped only on the current version.

• Package could not be installed: 4 packages

897 packages were skipped on the previous version too.

[adienes]

@nanosoldier runtests(["MethodInspector", "LazyModules", "UnzipLoops", "AssociatedLegendrePolynomials", "OddEvenIntegers", "PaddedViews", "CatIndices", "OffsetArrays", "TypeUtils", "RunningQuantiles", "LocalFilters", "IntegralArrays", "GeometricSolutions", "DataFlowTasks", "LACosmic", "ArrayInterfaceOffsetArrays", "TiledIteration", "FFTViews", "HistogramThresholding", "Sixel", "ImageTransformations", "FoldRNA", "Groebner", "AxisKeys", "PSRDatabase", "ImageSmooth", "ImageFiltering", "BasicTextRender", "SPECTrecon", "TrainingPhantoms", "SMLMMetrics", "GeoArrayOps", "ImageMorphology", "ImageEdgeDetection", "HierarchicalTemporalMemory", "ImageIO", "CompactBasisFunctions", "Augmentor", "BackgroundMeshes", "ImageInpainting", "MRICompress", "SMLMFrameConnection", "ImageQualityIndexes", "QuantitativeSusceptibilityMappingTGV", "CellSegmentation", "DeepFry", "CloudCovErr", "SpmGrids", "InstrumentOperator", "Photometry", "SimSpin", "ImgCIFHandler", "UVITTools", "PulseInputDDM", "Regions", "Ditherings", "MPITestImages", "Eikonal", "HoloProcessing", "ChaoticEncryption", "RemBG", "ComplexPhasePortrait", "ImageProjectiveGeometry", "Radiomics", "GigaScatter", "BundlerIO", "OtsuThresholding", "ImageUtils", "SpaSM", "CoralBlox", "PerceptualColourMaps", "UnfoldSim", "WebToys", "ImageHashes", "OliveImages", "AIBECS", "FinEtoolsVoxelMesher", "Colocalization", "Fable", "PGFPlots", "ChemfilesViewer", "FaceDetection", "Mellan", "Basins", "CriticalDifferenceDiagrams", "Repotomata", "ElectroPhysiology", "MPIReco", "PhysiologyPlotting", "FatDatasets", "Jchemo", "BlobTracking", "IceFloeTracker", "MAGEMinApp", "PhysiologyAnalysis", "HeartRateVariability", "JHistint", "LineIntegralConvolution", "Javis", "OrbisChessEngine", "MRINavigator", "Ecosons", "HmtGutenberg", "HmtArchive", "Graphene", "UnfoldMakie", "Mads", "MiseEnPage", "CanDecomp", "Test", "NeuroAnalysis", "NTFk", "SmartML", "NTNk", "GeoThermalCloud", "FundamentalsNumericalComputation", "GasChromatographySystems"])

[nanosoldier]

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

✖ Packages that failed

61 packages failed only on the current version.

• Package fails to precompile: 41 packages
• Package has test failures: 15 packages
• Package tests unexpectedly errored: 5 packages

52 packages failed on the previous version too.

✔ Packages that passed tests

4 packages passed tests on the previous version too.