Skip to content

Conversation

@adienes
Copy link
Member

@adienes adienes commented Sep 6, 2025

closes #48916 as suggested by @oscardssmith

I believe the more consistent behavior here would be for isless to error when comparing two Arrays a and b where eachindex(a,b)∉(eachindex(a), eachindex(b)) (similarly to how it works with Complex numbers or other collections like Dict that don't have an ordering.

@adienes adienes added bugfix This change fixes an existing bug collections Data structures holding multiple items, e.g. sets equality Issues relating to equality relations: ==, ===, isequal labels Sep 6, 2025
@nsajko nsajko added the arrays [a, r, r, a, y, s] label Sep 7, 2025
@adienes adienes changed the title max vector cmp match axes make vector cmp match axes Sep 7, 2025
@adienes

This comment was marked as outdated.

@nanosoldier

This comment was marked as outdated.

@adienes

This comment was marked as outdated.

@nanosoldier

This comment was marked as outdated.

@adienes

This comment was marked as outdated.

@adienes
Copy link
Member Author

adienes commented Sep 11, 2025

very tangential, but it's a shame to have to use exceptions here. partial orders seem like the perfect use case for a Some-or-nothing API

@adienes adienes reopened this Sep 12, 2025
@adienes
Copy link
Member Author

adienes commented Sep 12, 2025

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

❗ Packages that crashed

2 packages crashed on the previous version too.

✖ Packages that failed

21 packages failed only on the current version.

  • Package has test failures: 5 packages
  • Package tests unexpectedly errored: 1 packages
  • Networking-related issues were detected: 1 packages
  • Tests became inactive: 1 packages
  • Test duration exceeded the time limit: 13 packages

1339 packages failed on the previous version too.

✔ Packages that passed tests

13 packages passed tests only on the current version.

  • Other: 13 packages

5214 packages passed tests on the previous version too.

~ Packages that at least loaded

9 packages successfully loaded only on the current version.

  • Other: 9 packages

3196 packages successfully loaded on the previous version too.

➖ Packages that were skipped altogether

22 packages were skipped only on the current version.

  • Package could not be installed: 22 packages

1132 packages were skipped on the previous version too.

@adienes
Copy link
Member Author

adienes commented Sep 13, 2025

@nanosoldier runtests(["MethodInspector", "ClusteringGA", "Andes", "MetaGraphsNext", "IJulia", "KalmanFilters", "MatrixProfile", "PlantGeomTurtle", "MixedModelsMakie", "SBMLToolkitTestSuite"])

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

✖ Packages that failed

2 packages failed only on the current version.

  • Package has test failures: 1 packages
  • Package tests unexpectedly errored: 1 packages

2 packages failed on the previous version too.

✔ Packages that passed tests

1 packages passed tests only on the current version.

  • Other: 1 packages

4 packages passed tests on the previous version too.

~ Packages that at least loaded

1 packages successfully loaded on the previous version too.

@adienes
Copy link
Member Author

adienes commented Sep 26, 2025

bump

@martinholters
Copy link
Member

Looks reasonable to me. Should this be mentioned in the docs somewhere?

@adienes
Copy link
Member Author

adienes commented Sep 29, 2025

arguably comparing indices first is "already" lexicographic, and it's just a question of how do you align / zip the axes together, but good idea to spell that out explicitly

Copy link
Member

@jishnub jishnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@adienes
Copy link
Member Author

adienes commented Sep 29, 2025

CI failure is #59650

seeing two approvals: merging

@adienes adienes merged commit 39e1473 into JuliaLang:master Sep 29, 2025
5 of 7 checks passed
@adienes adienes deleted the lex_arr_cmp branch September 29, 2025 16:51
xal-0 pushed a commit to xal-0/julia that referenced this pull request Sep 30, 2025
closes JuliaLang#48916 as suggested by
@oscardssmith
> I believe the more consistent behavior here would be for isless to
error when comparing two Arrays a and b where
eachindex(a,b)∉(eachindex(a), eachindex(b)) (similarly to how it works
with Complex numbers or other collections like Dict that don't have an
ordering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug collections Data structures holding multiple items, e.g. sets equality Issues relating to equality relations: ==, ===, isequal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lexicographic order for AbstractVector is inconsistent

5 participants