Skip to content

Fix pretty printing of symbols by Test.jl #57430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nerdberg792 wants to merge 8 commits into from
Closed

Fix pretty printing of symbols by Test.jl #57430

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef5a831
updated Test.jl
nerdberg792 Feb 16, 2025
74ac899
Update Test.jl
nerdberg792 Feb 16, 2025
ebb028f
Merge branch 'master' into pretty
nerdberg792 Feb 16, 2025
686797d
Update Test.jl
nerdberg792 Feb 16, 2025
dc93fae
Update Test.jl
nerdberg792 Feb 16, 2025
fa35e1b
Update Test.jl
nerdberg792 Feb 16, 2025
92f307a
Update Test.jl
nerdberg792 Feb 19, 2025
ac9d1c9
Merge branch 'master' into pretty
LilithHafner Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions stdlib/Test/src/Test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,20 @@ function eval_test(evaluated::Expr, quoted::Expr, source::LineNumberNode, negate
if res
res = op(a, b)
end
quoted_args[i] = a
quoted_args[i+2] = b
if a isa Symbol
quoted_args[i] = QuoteNode(a)

@KristofferC KristofferC Feb 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it woud be better to put the whole logic into a function so it doesn't have to be repeated for both a and b.

@vtjnash vtjnash Feb 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That function is the existing Base.quoted function in this case

elseif Meta.isexpr(a, :call)

@KristofferC KristofferC Feb 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case is this used? What difference does it make?

quoted_args[i] = :($a)
else
quoted_args[i] = a
end
if b isa Symbol
quoted_args[i+2] = QuoteNode(b)
elseif Meta.isexpr(b, :call)
quoted_args[i+2] = :($b)
else
quoted_args[i+2] = b
end
i += 2
end

Expand Down