Fix pretty printing of symbols by Test.jl#57430
Fix pretty printing of symbols by Test.jl#57430nerdberg792 wants to merge 8 commits intoJuliaLang:masterfrom
Conversation
|
Can you edit the PR title to be a bit more descriptive, e.g. to briefly describe the bug that is being fixed. |
Removed whitespaces
I have made some changes can you review my PR , also I haven't added any tests to check for the aforementioned bug |
removed whitespaces
removed whitespace from line 367
removeed whitespaces
|
@KristofferC can you please point out where should I add the tests |
|
stdlib/Test/test/runtests.jl |
|
The last example in the first post is is already what is shown on master so not sure what is meant by that. |
stdlib/Test/src/Test.jl
Outdated
| quoted_args[i+2] = b | ||
| if a isa Symbol | ||
| quoted_args[i] = QuoteNode(a) | ||
| elseif Meta.isexpr(a, :call) |
There was a problem hiding this comment.
In which case is this used? What difference does it make?
stdlib/Test/src/Test.jl
Outdated
| quoted_args[i] = a | ||
| quoted_args[i+2] = b | ||
| if a isa Symbol | ||
| quoted_args[i] = QuoteNode(a) |
There was a problem hiding this comment.
I think it woud be better to put the whole logic into a function so it doesn't have to be repeated for both a and b.
There was a problem hiding this comment.
That function is the existing Base.quoted function in this case
On the previous changes , I misinterpret how the expressions need to be printed , fixed this here
I misinterpreted your comments on the issues , I have now made the necessary changes and it seems to work fine , can you please review this once , sorry for the inconvenience cause ! |
|
This looks good so far. Would you please address Jameson's comment by using |
|
@nerdberg792 Are you still interested in working on this? |
|
Closed by #61054 |
Fixes #57287
When we perform a Test :
But ideally the test should print
Evaluated 1 == :symI have changed the parsing of the arguments :
Updated Test.jl and added some if else conditions :
now the tests mentioned in the issue yields these results :